Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.9.0
    • Component/s: RPC
    • Labels:
      None

      Description

      HashedWheelTimer creates a new thread whenever it is instantiated and started. Therefore, We should to share the instance
      refer to http://netty.io/3.6/api/org/jboss/netty/util/HashedWheelTimer.html

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/141

        TAJO-1040: Misuse netty HashedWheelTimer.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1040

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/141.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #141


        commit 079afdc1ee5175ff1e72360ee7d9ec49795aeb61
        Author: jhkim <jhkim@apache.org>
        Date: 2014-09-16T07:31:40Z

        TAJO-1040: Misuse netty HashedWheelTimer.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/141 TAJO-1040 : Misuse netty HashedWheelTimer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1040 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 079afdc1ee5175ff1e72360ee7d9ec49795aeb61 Author: jhkim <jhkim@apache.org> Date: 2014-09-16T07:31:40Z TAJO-1040 : Misuse netty HashedWheelTimer.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/141#issuecomment-55741218

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/141#issuecomment-55741218 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/141#issuecomment-55853758

        committed

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/141#issuecomment-55853758 committed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy closed the pull request at:

        https://github.com/apache/tajo/pull/141

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy closed the pull request at: https://github.com/apache/tajo/pull/141
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #360 (See https://builds.apache.org/job/Tajo-master-build/360/)
        TAJO-1040: Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c)

        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #360 (See https://builds.apache.org/job/Tajo-master-build/360/ ) TAJO-1040 : Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c) tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #2 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/2/)
        TAJO-1040: Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c)

        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #2 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/2/ ) TAJO-1040 : Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c) tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #3 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/3/)
        TAJO-1040: Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c)

        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #3 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/3/ ) TAJO-1040 : Misuse netty HashedWheelTimer. (jinho) (jhkim: rev 1a8a67ceb4224f3f0f3adab7d3e8956d3d12137c) tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/Task.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development