Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1022

tsql does not work as background process

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      The following command doesn't work

      1. bin/tsql -f test.sql &

      It's caused by JLine's ConsoleReader.

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Fixing it as resolved.

        Show
        hyunsik Hyunsik Choi added a comment - Fixing it as resolved.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #354 (See https://builds.apache.org/job/Tajo-master-build/354/)
        TAJO-1022: tsql does not work as background process (babokim: rev 604eb32222d9bdfb4f6768a863472ec46776cb90)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #354 (See https://builds.apache.org/job/Tajo-master-build/354/ ) TAJO-1022 : tsql does not work as background process (babokim: rev 604eb32222d9bdfb4f6768a863472ec46776cb90) CHANGES tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/128

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/128
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-55208117

        +1

        Ship it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-55208117 +1 Ship it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-55207692

        There is no special reason. I thought that this mode is not a typical mode so I used 'B' instead of 'b'.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-55207692 There is no special reason. I thought that this mode is not a typical mode so I used 'B' instead of 'b'.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-55072962

        It needs rebase. Also, I have one suggestion. We have used lower case characters as options. Like ```-B```, ```-b``` also can indicate background. Do you have any reason using upper case?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-55072962 It needs rebase. Also, I have one suggestion. We have used lower case characters as options. Like ```-B```, ```-b``` also can indicate background. Do you have any reason using upper case?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-54622628

        I pushed new patch. I added "-B" option for running CLI as background. This is a temporal solution. If you find a better way this patch should be replaced.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-54622628 I pushed new patch. I added "-B" option for running CLI as background. This is a temporal solution. If you find a better way this patch should be replaced.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-54146558

        Nice catch hyunsik. I did't realize that problem.
        I found that hive shell have same problem. See the following site.
        https://issues.apache.org/jira/browse/HIVE-6758
        Hive does not support "jline.UnsupportedTerminal" option, but documented a workaround.

        In my opinion many tajo query will be run as background mode, so background mode option is good to user.
        What do you think about "-B" as background mode option like the bellow.

        "bin/tsql -B -t test.sql &"

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-54146558 Nice catch hyunsik. I did't realize that problem. I found that hive shell have same problem. See the following site. https://issues.apache.org/jira/browse/HIVE-6758 Hive does not support "jline.UnsupportedTerminal" option, but documented a workaround. In my opinion many tajo query will be run as background mode, so background mode option is good to user. What do you think about "-B" as background mode option like the bellow. "bin/tsql -B -t test.sql &"
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-54123741

        When this patch is applied, the arrow and esc keys does not work anymore. As a temporary solution, we can add some option for non-interactive mode for background job. How do you think?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-54123741 When this patch is applied, the arrow and esc keys does not work anymore. As a temporary solution, we can add some option for non-interactive mode for background job. How do you think?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/128#issuecomment-54015091

        +1
        Great!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/128#issuecomment-54015091 +1 Great!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/128

        TAJO-1022: tsql does not work as background process

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-1022

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/128.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #128


        commit 4746555319a2429fc047c7e7f0f0f9fd2d79cd73
        Author: HyoungJun Kim <babokim@babokim-macbook-pro.local>
        Date: 2014-08-31T18:33:48Z

        TAJO-1022: tsql does not work as background process


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/128 TAJO-1022 : tsql does not work as background process You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-1022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit 4746555319a2429fc047c7e7f0f0f9fd2d79cd73 Author: HyoungJun Kim <babokim@babokim-macbook-pro.local> Date: 2014-08-31T18:33:48Z TAJO-1022 : tsql does not work as background process

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development