Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1009

A binary eval for column references of the same tables should not be recognized as a join condition

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      See the following example:

      SELECT a,b,c from table1 where table1.a > table1.b;
      

      EvalTreeUtil.isJoinQual recognizes the above predicate as a join qual. It's wrong.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/121

        TAJO-1009: A binary eval for column references of the same tables should...

        ... not be recognized as a join condition.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1009

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/121.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #121


        commit 51c0c3a358e586f772bd1880f45d7d0000f3970c
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-08-18T02:30:39Z

        TAJO-1009: A binary eval for column references of the same tables should not be recognized as a join condition.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/121 TAJO-1009 : A binary eval for column references of the same tables should... ... not be recognized as a join condition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1009 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 51c0c3a358e586f772bd1880f45d7d0000f3970c Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-08-18T02:30:39Z TAJO-1009 : A binary eval for column references of the same tables should not be recognized as a join condition.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/121#issuecomment-52470430

        +1

        It looks good to me and unit test case finished successfully.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/121#issuecomment-52470430 +1 It looks good to me and unit test case finished successfully.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/121#issuecomment-52471736

        Thank you for the quick review. I'll commit it shortly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/121#issuecomment-52471736 Thank you for the quick review. I'll commit it shortly.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/121

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/121
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #339 (See https://builds.apache.org/job/Tajo-master-build/339/)
        TAJO-1009: A binary eval for column references of the same tables should not be recognized as a join condition. (hyunsik: rev 96b6c2aad76837c42d894b4aa217c6641e72ec86)

        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #339 (See https://builds.apache.org/job/Tajo-master-build/339/ ) TAJO-1009 : A binary eval for column references of the same tables should not be recognized as a join condition. (hyunsik: rev 96b6c2aad76837c42d894b4aa217c6641e72ec86) CHANGES tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development