Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1000

TextDatum.asChar() is incorrect, if client charset is different

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: Data Type
    • Labels:
      None

      Description

      Currently, a TextDatum is UTF-8 encoded bytes. if a client sets different default charset, TextDatum should change to the correct charset

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #335 (See https://builds.apache.org/job/Tajo-master-build/335/)
        TAJO-1000: TextDatum.asChar() is incorrect, if client charset is different. (jinho) (jhkim: rev fb4135a3bf16e61345ca2a5b6a6fea5b516e7a3e)

        • tajo-project/pom.xml
        • tajo-common/pom.xml
        • tajo-common/src/test/java/org/apache/tajo/datum/TestTextDatum.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #335 (See https://builds.apache.org/job/Tajo-master-build/335/ ) TAJO-1000 : TextDatum.asChar() is incorrect, if client charset is different. (jinho) (jhkim: rev fb4135a3bf16e61345ca2a5b6a6fea5b516e7a3e) tajo-project/pom.xml tajo-common/pom.xml tajo-common/src/test/java/org/apache/tajo/datum/TestTextDatum.java CHANGES tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/112#issuecomment-52013051

        committed it! thank you!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/112#issuecomment-52013051 committed it! thank you!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy closed the pull request at:

        https://github.com/apache/tajo/pull/112

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy closed the pull request at: https://github.com/apache/tajo/pull/112
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/112#issuecomment-52005900

        +1

        LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/112#issuecomment-52005900 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/112

        TAJO-1000: TextDatum.asChar() is incorrect, if client charset is different

        Currently, a TextDatum is UTF-8 encoded bytes. if a client sets different default charset, TextDatum should change to the correct charset

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1000

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/112.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #112


        commit a1aa9545e2c3a0e4be673ed474665ee8b251810f
        Author: jinossy <jinossy@gmail.com>
        Date: 2014-08-11T05:51:51Z

        TAJO-1000: TextDatum.asChar() is incorrect, if client charset is different


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/112 TAJO-1000 : TextDatum.asChar() is incorrect, if client charset is different Currently, a TextDatum is UTF-8 encoded bytes. if a client sets different default charset, TextDatum should change to the correct charset You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1000 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #112 commit a1aa9545e2c3a0e4be673ed474665ee8b251810f Author: jinossy <jinossy@gmail.com> Date: 2014-08-11T05:51:51Z TAJO-1000 : TextDatum.asChar() is incorrect, if client charset is different

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development