[SYSTEMDS-3154] Get Instruction Strings of Different Input Sizes With a Single Method in Dag.java

• Type: Improvement
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: Compiler
• Assignee: Unassigned
• Reporter: Sebastian Wrede
• Created: 08/Oct/21 14:17
• Updated: 08/Oct/21 14:19

Description

In Dag.java, an if-else structure has been created to call different methods depending on the number of inputs to the node. See: https://github.com/apache/systemds/blob/cba31ad00f66dc8b3a71a679241621eafc2f8e91/src/main/java/org/apache/sysds/lops/compile/Dag.java#L636-L691

All method calls are doing the same thing, so a loop over a list of the inputs could achieve the same thing.

This would require a change of the getInstructions method to handle a list of inputs instead. This would also require a change in several of the Lop subclasses to inherit from the changed getInstructions method.