[SYSTEMDS-152] Rename static readDML... and readR... methods in AutomatedTestBase

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: SystemDS 2.1
• Component/s: Test
• Assignee: Mark Dokter
• Reporter: Jon Deron Eriksson
• Created: 15/Aug/15 00:00
• Updated: 02/Nov/20 17:11
• Resolved: 02/Nov/20 17:11

Description

Right now in AutomatedTestBase class, readDMLMatrixFromHDFS() method reads a file from OUTPUT_DIR, readDMLScalarFromHDFS() method reads a file from OUTPUT_DIR, readRMatrixFromFS() method reads a file from EXPECTED_DIR, and readRScalarFromFS() method reads a file from EXPECTED_DIR.

Changing method names so that they reflect where the read is coming from (OUTPUT_DIR or EXPECTED_DIR) would be very helpful in terms of visual comprehension of the test code so that the internals of the methods don't need to be looked at to determine functionality. Additionally, the mention of HDFS and FS is not necessarily relevant.

Potential name changes:
readDMLMatrixFromHDFS --> readDMLMatrixFromOutputDir
readDMLScalarFromHDFS --> readDMLScalarFromOutputDir
readRMatrixFromFS --> readRMatrixFromExpectedDir
readRScalarFromFS --> readRScalarFromExpectedDir