[SYSTEMDS-151] AutomatedTestBase calls deprecated TestUtils methods

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: SystemDS 2.1
• Component/s: Test
• Assignee: Mark Dokter
• Reporter: Jon Deron Eriksson
• Created: 14/Aug/15 23:30
• Updated: 02/Nov/20 16:52
• Resolved: 02/Nov/20 16:52

Description

The TestUtils.readDMLMatrixFromHDFS() and TestUtils.readRMatrixFromFS() methods are deprecated.

The AutomatedTestBase.readDMLMatrixFromHDFS() method calls TestUtils.readDMLMatrixFromHDFS() and the AutomatedTestBase.readRMatrixFromFS() method calls TestUtils.readRMatrixFromFS(). The AutomatedTestBase methods are annotated with @SuppressWarnings("deprecation").

Rather than have suppressed-deprecation-warning methods call their equivalent deprecated methods, we have other options:
1) Don't deprecate the TestUtils methods. If AutomatedTestBase methods should be used, explain reasoning in the Javadoc comments.
2) Remove deprecated methods from TestUtils and replace them with 'good' versions of these methods in TestUtils or move the functionality to where it is intended.