[SYSTEMDS-1173] DataExpression and StringIdentifier toString readability

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: SystemML 0.13
• Component/s: Parser
• Assignee: Jon Deron Eriksson
• Reporter: Jon Deron Eriksson
• Created: 11/Jan/17 20:09
• Updated: 03/Mar/17 21:25
• Resolved: 23/Jan/17 19:31

Description

Improve readability of StringIdentifier and DataExpression toString methods.

For example, A = matrix("1 2 3 4 5 6", rows=3, cols=2) results in a DMLProgram that contains:

A = RAND(,lambda=1.0,min=1 2 3 4 5 6,pdf=uniform,seed=-1,max=1 2 3 4 5 6,sparsity=1.0,rows=3,cols=2 );

The extraneous first comma within RAND is confusing. Additionally, the string '1 2 3 4 5 6' is not surrounded by quotes, which affects readability.

Readability is improved if the toStrings are modified to produce output such as the following:

A = RAND(lambda=1.0, min='1 2 3 4 5 6', pdf='uniform', seed=-1, max='1 2 3 4 5 6', sparsity=1.0, rows=3, cols=2);