Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0.M5
    • Component/s: ide
    • Labels:
    • Environment:
      Eclipse

      Description

      Develop a plug-in, according to what reported in SYNCOPE-770, working with latest Eclipse version.

      See Google Summer of Code project proposal at https://summerofcode.withgoogle.com/projects/#4822214733987840

        Issue Links

          Activity

          Hide
          tusharm Tushar Mishra added a comment -

          The plugin is being developed and is in sync with it's github repo: https://github.com/tmess567/SYNCOPE-809.
          Also, updates made and issues faced are being discussed on the syncope-dev mailing list. See http://markmail.org/message/pdhu2rlcxq4plwe3

          Show
          tusharm Tushar Mishra added a comment - The plugin is being developed and is in sync with it's github repo: https://github.com/tmess567/SYNCOPE-809 . Also, updates made and issues faced are being discussed on the syncope-dev mailing list. See http://markmail.org/message/pdhu2rlcxq4plwe3
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tmess567 opened a pull request:

          https://github.com/apache/syncope/pull/28

          Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope)

          Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope) : Allows user to view and edit Mail Templates and Report Templates from Eclipse itself)

          Based on the latest [commit](https://github.com/tmess567/SYNCOPE-809/commit/ce3135ce56251d618edd90f8af07ef6df8497aea). I also have some things to ask, please view the inline comments.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tmess567/syncope SYNCOPE-809

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/syncope/pull/28.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #28


          commit f84cad4cf08afb6529eb9548f7db5ba2f8c9466b
          Author: Tushar <tusharm567@gmail.com>
          Date: 2016-07-20T14:07:04Z

          Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tmess567 opened a pull request: https://github.com/apache/syncope/pull/28 Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope) Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope) : Allows user to view and edit Mail Templates and Report Templates from Eclipse itself) Based on the latest [commit] ( https://github.com/tmess567/SYNCOPE-809/commit/ce3135ce56251d618edd90f8af07ef6df8497aea ). I also have some things to ask, please view the inline comments. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tmess567/syncope SYNCOPE-809 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/syncope/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit f84cad4cf08afb6529eb9548f7db5ba2f8c9466b Author: Tushar <tusharm567@gmail.com> Date: 2016-07-20T14:07:04Z Syncope-809 GSoC Project (Eclipse Plugin for Apache Syncope)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tmess567 commented on a diff in the pull request:

          https://github.com/apache/syncope/pull/28#discussion_r71652297

          — Diff: ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/META-INF/MANIFEST.MF —
          @@ -0,0 +1,48 @@
          +Manifest-Version: 1.0
          +Bundle-ManifestVersion: 2
          +Bundle-Name: Plugin
          +Bundle-SymbolicName: org.apache.syncope.ide.eclipse.plugin;singleton:=true
          +Bundle-Version: 2.0.0.qualifier
          — End diff –

          The qualifier maps to STANDALONE
          Which is why the jar, the archive and the p2 site built is named "org.apache.syncope.ide.eclipse.plugin-2.0.0-SNAPSHOT"

          The version number can be changed using a plugin.properties file, but this will again lead to the same problems as faced in [this issue](https://github.com/tmess567/SYNCOPE-809/issues/9).

          Also, this version number must be the same as in the pom or else it will throw the following error.
          ```
          [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.25.0:validate-version (default-validate-version) on project org.apache.syncope.ide.eclipse.plugin: Unqualified OSGi version 1.0.0.qualifier must match unqualified Maven version 2.0.0-SNAPSHOT for SNAPSHOT builds
          ```
          It would be better if this remains static and is changed whenever required.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tmess567 commented on a diff in the pull request: https://github.com/apache/syncope/pull/28#discussion_r71652297 — Diff: ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/META-INF/MANIFEST.MF — @@ -0,0 +1,48 @@ +Manifest-Version: 1.0 +Bundle-ManifestVersion: 2 +Bundle-Name: Plugin +Bundle-SymbolicName: org.apache.syncope.ide.eclipse.plugin;singleton:=true +Bundle-Version: 2.0.0.qualifier — End diff – The qualifier maps to STANDALONE Which is why the jar, the archive and the p2 site built is named "org.apache.syncope.ide.eclipse.plugin-2.0.0-SNAPSHOT" The version number can be changed using a plugin.properties file, but this will again lead to the same problems as faced in [this issue] ( https://github.com/tmess567/SYNCOPE-809/issues/9 ). Also, this version number must be the same as in the pom or else it will throw the following error. ``` [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.25.0:validate-version (default-validate-version) on project org.apache.syncope.ide.eclipse.plugin: Unqualified OSGi version 1.0.0.qualifier must match unqualified Maven version 2.0.0-SNAPSHOT for SNAPSHOT builds ``` It would be better if this remains static and is changed whenever required.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ilgrosso commented on the issue:

          https://github.com/apache/syncope/pull/28

          I have made some adjustments to Maven and now things seem to work fine: please review and apply the attached [SYNCOPE-809-Maven-diff.txt](https://github.com/apache/syncope/files/377683/SYNCOPE-809-Maven-diff.txt) (it's the output of `git diff`, you can apply it with `patch -p1`) to your fork, then commit.

          Once done that, I'd say we still have to address an issue before merging: I have noticed that the P2 site contains under `repository/plugins/` several JAR files which should IMO downloaded from elsewhere (e.g. the main Eclipse update site): do you think it could be possible to leave just `org.apache.syncope.ide.eclipse.plugin_XXX.jar` there?

          Other tasks that can be handled *after* merging this PR:

          1. Multiple LICENSE / NOTICE files are available in the generated P2 site: they should all removed and new ones should be provided on the root directory of the P2 site, reflecting the actual content of `org.apache.syncope.ide.eclipse.plugin_XXX.jar` (I can take care of this)

          1. The [release process](http://syncope.apache.org/release-process.html) needs to be adjusted for manually signing the artifacts in the P2 site (I can take care of this)

          1. Various functional and non-functional improvements to plugin features

          Show
          githubbot ASF GitHub Bot added a comment - Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/28 I have made some adjustments to Maven and now things seem to work fine: please review and apply the attached [SYNCOPE-809-Maven-diff.txt] ( https://github.com/apache/syncope/files/377683/SYNCOPE-809-Maven-diff.txt ) (it's the output of `git diff`, you can apply it with `patch -p1`) to your fork, then commit. Once done that, I'd say we still have to address an issue before merging: I have noticed that the P2 site contains under `repository/plugins/` several JAR files which should IMO downloaded from elsewhere (e.g. the main Eclipse update site): do you think it could be possible to leave just `org.apache.syncope.ide.eclipse.plugin_XXX.jar` there? Other tasks that can be handled * after * merging this PR: 1. Multiple LICENSE / NOTICE files are available in the generated P2 site: they should all removed and new ones should be provided on the root directory of the P2 site, reflecting the actual content of `org.apache.syncope.ide.eclipse.plugin_XXX.jar` (I can take care of this) 1. The [release process] ( http://syncope.apache.org/release-process.html ) needs to be adjusted for manually signing the artifacts in the P2 site (I can take care of this) 1. Various functional and non-functional improvements to plugin features
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6fee50d752f655c6fbef22ecdf24b27025e661af in syncope's branch refs/heads/master from Tushar Mishra
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=6fee50d ]

          SYNCOPE-809 GSoC Project (Eclipse Plugin for Apache Syncope) - This closes #28

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6fee50d752f655c6fbef22ecdf24b27025e661af in syncope's branch refs/heads/master from Tushar Mishra [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=6fee50d ] SYNCOPE-809 GSoC Project (Eclipse Plugin for Apache Syncope) - This closes #28
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/syncope/pull/28

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/syncope/pull/28
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1f62e6fb91d0766a85015a99bf1269ad6eadf6f5 in syncope's branch refs/heads/master from Francesco Chicchiriccò
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=1f62e6f ]

          SYNCOPE-809 Adjusting LICENSE / NOTICE, release process and downloads

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1f62e6fb91d0766a85015a99bf1269ad6eadf6f5 in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=1f62e6f ] SYNCOPE-809 Adjusting LICENSE / NOTICE, release process and downloads
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b6bd80bee8fc9a3bfdc8b89c265d978d93c0a4e9 in syncope's branch refs/heads/master from Francesco Chicchiriccò
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=b6bd80b ]

          SYNCOPE-809 Restoring build: need some adjustment to work with the site profile

          Show
          jira-bot ASF subversion and git services added a comment - Commit b6bd80bee8fc9a3bfdc8b89c265d978d93c0a4e9 in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=b6bd80b ] SYNCOPE-809 Restoring build: need some adjustment to work with the site profile
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1b325bb8e8ed2305a69f85adca6478aadaf30cb2 in syncope's branch refs/heads/master from Francesco Chicchiriccò
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=1b325bb ]

          SYNCOPE-809 Fixing -Psite build problems

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1b325bb8e8ed2305a69f85adca6478aadaf30cb2 in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=1b325bb ] SYNCOPE-809 Fixing -Psite build problems
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ilgrosso commented on the issue:

          https://github.com/apache/syncope/pull/31

          I've added some comments, please address.

          I am also adding explicit reference to SYNCOPE-809 so that this PR gets linked to JIRA (as the "Syncope 809" subject won't work for this purpose).

          Show
          githubbot ASF GitHub Bot added a comment - Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/31 I've added some comments, please address. I am also adding explicit reference to SYNCOPE-809 so that this PR gets linked to JIRA (as the "Syncope 809" subject won't work for this purpose).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7bd465636f0985d1e376479d0664d0dc3ddec4f3 in syncope's branch refs/heads/master from Francesco Chicchiriccò
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=7bd4656 ]

          SYNCOPE-809 Fixing javadoc errors

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7bd465636f0985d1e376479d0664d0dc3ddec4f3 in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=7bd4656 ] SYNCOPE-809 Fixing javadoc errors
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ilgrosso commented on the issue:

          https://github.com/apache/syncope/pull/34

          Linking to SYNCOPE-809

          Show
          githubbot ASF GitHub Bot added a comment - Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/34 Linking to SYNCOPE-809
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04941418ad182489e0f45eb450fad8141897faed in syncope's branch refs/heads/master from Tushar Mishra
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=0494141 ]

          SYNCOPE-809 Added Tests for Eclipse Plugin - This closes #34

          Show
          jira-bot ASF subversion and git services added a comment - Commit 04941418ad182489e0f45eb450fad8141897faed in syncope's branch refs/heads/master from Tushar Mishra [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=0494141 ] SYNCOPE-809 Added Tests for Eclipse Plugin - This closes #34
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tmess567 opened a pull request:

          https://github.com/apache/syncope/pull/35

          Fixing HTMLEditor Resource Bundle location SYNCOPE-809

          This also fixes the testing problem with the HTMLEditor as stated in #34 .
          However, the StructuredTextEditor still malfunctions during the swtbot tests.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tmess567/syncope SYNCOPE-809-tests

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/syncope/pull/35.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #35


          commit 9c30ff8eeedee2c7fda82471d99a0ad6c01150a0
          Author: Tushar <tusharm567@gmail.com>
          Date: 2016-08-22T10:42:25Z

          Fixing HTMLEditor Resource Bundle location


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tmess567 opened a pull request: https://github.com/apache/syncope/pull/35 Fixing HTMLEditor Resource Bundle location SYNCOPE-809 This also fixes the testing problem with the HTMLEditor as stated in #34 . However, the StructuredTextEditor still malfunctions during the swtbot tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tmess567/syncope SYNCOPE-809 -tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/syncope/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 9c30ff8eeedee2c7fda82471d99a0ad6c01150a0 Author: Tushar <tusharm567@gmail.com> Date: 2016-08-22T10:42:25Z Fixing HTMLEditor Resource Bundle location
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c304ad72dcd6d71a97cc73f9f3e96b1aac39d9b in syncope's branch refs/heads/master from Tushar Mishra
          [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=5c304ad ]

          SYNCOPE-809 Fixing HTMLEditor Resource Bundle location

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c304ad72dcd6d71a97cc73f9f3e96b1aac39d9b in syncope's branch refs/heads/master from Tushar Mishra [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=5c304ad ] SYNCOPE-809 Fixing HTMLEditor Resource Bundle location
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tmess567 commented on the issue:

          https://github.com/apache/syncope/pull/35

          Closed with 5c304ad72dcd6d71a97cc73f9f3e96b1aac39d9b

          Show
          githubbot ASF GitHub Bot added a comment - Github user tmess567 commented on the issue: https://github.com/apache/syncope/pull/35 Closed with 5c304ad72dcd6d71a97cc73f9f3e96b1aac39d9b
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tmess567 closed the pull request at:

          https://github.com/apache/syncope/pull/35

          Show
          githubbot ASF GitHub Bot added a comment - Github user tmess567 closed the pull request at: https://github.com/apache/syncope/pull/35
          Hide
          ilgrosso Francesco Chicchiriccò added a comment -

          Bulk close for 2.0.0-M5

          Show
          ilgrosso Francesco Chicchiriccò added a comment - Bulk close for 2.0.0-M5
          Hide
          ilgrosso Francesco Chicchiriccò added a comment -

          Re-opening for interrupting 2.0.0-M5 attempt

          Show
          ilgrosso Francesco Chicchiriccò added a comment - Re-opening for interrupting 2.0.0-M5 attempt
          Hide
          ilgrosso Francesco Chicchiriccò added a comment -

          Bulk close for 2.0.0.M5

          Show
          ilgrosso Francesco Chicchiriccò added a comment - Bulk close for 2.0.0.M5

            People

            • Assignee:
              tusharm Tushar Mishra
              Reporter:
              ilgrosso Francesco Chicchiriccò
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development