[SYNCOPE-707] ConfigurationLogic doesn't check the existence of key during deletion.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.5, 2.0.0-M1
• Fix Version/s: 1.2.6, 2.0.0-M1
• Assignee: Massimiliano Perrone
• Reporter: Massimiliano Perrone
• Created: 13/Oct/15 11:12
• Updated: 05/Nov/15 09:29
• Resolved: 13/Oct/15 14:04

Description

When I try to delete a configuration I get always a valid response also when the configuration key doesn't exist (while I was expecting a NotFound error).
Reading the code I found below difference from (1) ConfigurationLogic and, for instance, (2) SchemaLogic classes:

(1)
@PreAuthorize("hasRole('" + Entitlement.CONFIGURATION_DELETE + "')")
public void delete(final String schema)

{ confDAO.delete(schema); }

(2)
@PreAuthorize("hasRole('" + Entitlement.SCHEMA_DELETE + "')")
public void delete(final SchemaType schemaType, final String schemaName) {
if (!doesSchemaExist(schemaType, schemaName))

{ throw new NotFoundException(schemaType + "/" + schemaName); }

switch (schemaType)

{ case VIRTUAL: virSchemaDAO.delete(schemaName); break; case DERIVED: derSchemaDAO.delete(schemaName); break; case PLAIN: default: plainSchemaDAO.delete(schemaName); }

}

As you can read the second class has a control on schema existence, the first one hasn't.

We have to add the same check on the ConfigurationLogic class.

Relevant mail thread: http://markmail.org/message/3ufidttokvw2km5k