Uploaded image for project: 'Syncope'
  1. Syncope
  2. SYNCOPE-417

Users are made active when updating in NoOpWorkflowAdapter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.3
    • Fix Version/s: 1.1.4, 1.2.0-M1
    • Component/s: core
    • Labels:
      None

      Description

      When using the NoOpWorkflow adapter a user is always set to active when an update is done, even if the user is suspended. This is undesirable, I think a user should stay in the state it is.

      This can be fixed by changing this line (117/118 of NoOpWorkflowAdapter.java):

      return new WorkflowResult<Map.Entry<Long, Boolean>>(
      new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), true), propByRes, "update");
      into this:

      return new WorkflowResult<Map.Entry<Long, Boolean>>(
      new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), !user.isSuspended()), propByRes, "update");

        Attachments

          Activity

            People

            • Assignee:
              ilgrosso Francesco Chicchiriccò
              Reporter:
              jessevanbekkum Jesse van Bekkum
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: