Syncope
  1. Syncope
  2. SYNCOPE-259

Create transitional Service interfaces and switch tests and console to use them

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: client, console, core
    • Labels:
      None

      Description

      As preparation of the change to use CXF instead of Spring MVC REST controllers this issue is to introduce transitional service interfaces (like as UserService).

      The UserService interface should later be used in the core to provide the UserController and on the console to access the service remotely.

      To make the transition easier the idea is to already introduce the interface upfront and change all tests and the console to use it. Before the switch the implementation of the interface will simply use the restTemplate under the covers.

      This to be applied similarly to all Spring MVC REST controllers.

      1. PolicyService.patch
        14 kB
        Andrei Shakirin
      2. ResourceService-1428511.patch
        23 kB
        Andrei Shakirin
      3. ResourceService.patch
        21 kB
        Andrei Shakirin
      4. SYNCOPE-259.patch
        58 kB
        Christian Schneider

        Issue Links

          Activity

          Hide
          Francesco Chicchiriccò added a comment -

          Bulk close for 1.1.0

          Show
          Francesco Chicchiriccò added a comment - Bulk close for 1.1.0
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #438 (See https://builds.apache.org/job/Syncope-trunk/438/)
          SYNCOPE-259

          • Updating Login module to use Spring REST Proxies
          • Removing obsolete comment (Revision 1433883)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/Login.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #438 (See https://builds.apache.org/job/Syncope-trunk/438/ ) SYNCOPE-259 Updating Login module to use Spring REST Proxies Removing obsolete comment (Revision 1433883) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/Login.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #437 (See https://builds.apache.org/job/Syncope-trunk/437/)
          SYNCOPE-259 SYNCOPE-172 Removing confusing toString() from AttributableType breaking ResourceMappingPanel + adding some final keywords to ResourceServiceProxy (this should be taken as standard practcice as other defined PMD / Findbugs / Checkstyle rules) (Revision 1433846)

          Result = SUCCESS
          ilgrosso :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/types/AttributableType.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourceMappingPanel.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #437 (See https://builds.apache.org/job/Syncope-trunk/437/ ) SYNCOPE-259 SYNCOPE-172 Removing confusing toString() from AttributableType breaking ResourceMappingPanel + adding some final keywords to ResourceServiceProxy (this should be taken as standard practcice as other defined PMD / Findbugs / Checkstyle rules) (Revision 1433846) Result = SUCCESS ilgrosso : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/types/AttributableType.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourceMappingPanel.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #436 (See https://builds.apache.org/job/Syncope-trunk/436/)
          CompleteSYNCOPE-259
          Completed missing Proxy methods (Revision 1433497)
          SYNCOPE-259
          Switching console to use Spring REST Proxies (Revision 1433457)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java

          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeApplication.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/AbstractAttributableRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ApprovalRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/AuthRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/BaseRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ConfigurationRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ConnectorRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/LoggerRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/NotificationRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/PolicyRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ResourceRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/RoleRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/SchemaRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/TaskRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/UserRequestRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/UserRestClient.java
          • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/WorkflowRestClient.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #436 (See https://builds.apache.org/job/Syncope-trunk/436/ ) Complete SYNCOPE-259 Completed missing Proxy methods (Revision 1433497) SYNCOPE-259 Switching console to use Spring REST Proxies (Revision 1433457) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeApplication.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/AbstractAttributableRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ApprovalRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/AuthRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/BaseRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ConfigurationRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ConnectorRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/LoggerRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/NotificationRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/PolicyRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/ResourceRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/RoleRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/SchemaRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/TaskRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/UserRequestRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/UserRestClient.java /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/WorkflowRestClient.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #434 (See https://builds.apache.org/job/Syncope-trunk/434/)
          SYNCOPE-259 Fixed policy service list method. (Revision 1433389)

          Result = SUCCESS
          ashakirin :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #434 (See https://builds.apache.org/job/Syncope-trunk/434/ ) SYNCOPE-259 Fixed policy service list method. (Revision 1433389) Result = SUCCESS ashakirin : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #431 (See https://builds.apache.org/job/Syncope-trunk/431/)
          SYNCOPE-259
          Replacing Class<T> method parameters with matching Enum types. (Revision 1433313)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringRestTemplate.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/types/AttributableType.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/types/TaskType.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #431 (See https://builds.apache.org/job/Syncope-trunk/431/ ) SYNCOPE-259 Replacing Class<T> method parameters with matching Enum types. (Revision 1433313) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringRestTemplate.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/types/AttributableType.java /syncope/trunk/client/src/main/java/org/apache/syncope/types/TaskType.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java
          Hide
          Jan Bernhardt added a comment -

          Hi Andrei,
          I would also prefer a solution without additional dependencies in our code. So +1 for second option.

          Show
          Jan Bernhardt added a comment - Hi Andrei, I would also prefer a solution without additional dependencies in our code. So +1 for second option.
          Hide
          Andrei Shakirin added a comment -

          For PolicyService, SchemaService and TaskService there are two possibilities to marshal / unmarshal Collections containing abstract type:
          1) Use Jackson JSON provider and Jackson specific annotation @JsonTypeInfo. Jackson additionally sends class information with each collection element
          2) Use CXF JSONProvider and jaxbElementClassNames property.

          (2) way is more attractive from my perspective, because we are not depends on Jackson.

          Show
          Andrei Shakirin added a comment - For PolicyService, SchemaService and TaskService there are two possibilities to marshal / unmarshal Collections containing abstract type: 1) Use Jackson JSON provider and Jackson specific annotation @JsonTypeInfo. Jackson additionally sends class information with each collection element 2) Use CXF JSONProvider and jaxbElementClassNames property. (2) way is more attractive from my perspective, because we are not depends on Jackson.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #421 (See https://builds.apache.org/job/Syncope-trunk/421/)
          SYNCOPE-259

          • Service Cleanup (removed deprecated annotations, removed obsolete comments)
          • SchemaService refactoring to use new SchemaType instead of SchemaTO classes in method signature (Revision 1431255)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/NotificationService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/types/AuditLoggerName.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/LoggerTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #421 (See https://builds.apache.org/job/Syncope-trunk/421/ ) SYNCOPE-259 Service Cleanup (removed deprecated annotations, removed obsolete comments) SchemaService refactoring to use new SchemaType instead of SchemaTO classes in method signature (Revision 1431255) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/NotificationService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/types/AuditLoggerName.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/LoggerTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #418 (See https://builds.apache.org/job/Syncope-trunk/418/)
          SYNCOPE-259 Fixing minor issues on WorkflowTestITCase (Revision 1430794)

          Result = SUCCESS
          ilgrosso :
          Files :

          • /syncope/trunk/core/src/main/java/org/apache/syncope/core/init/SpringContextInitializer.java
          • /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/WorkflowController.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/WorkflowTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #418 (See https://builds.apache.org/job/Syncope-trunk/418/ ) SYNCOPE-259 Fixing minor issues on WorkflowTestITCase (Revision 1430794) Result = SUCCESS ilgrosso : Files : /syncope/trunk/core/src/main/java/org/apache/syncope/core/init/SpringContextInitializer.java /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/WorkflowController.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/WorkflowTestITCase.java
          Hide
          Andrei Shakirin added a comment -

          Regarding PolicyService, SchemaService and TaskService - I am investigating the best way to marshal/unmarshal lists containing abstract types using JSON in CXF

          Show
          Andrei Shakirin added a comment - Regarding PolicyService, SchemaService and TaskService - I am investigating the best way to marshal/unmarshal lists containing abstract types using JSON in CXF
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #417 (See https://builds.apache.org/job/Syncope-trunk/417/)
          SYNCOPE-259
          Introduces User Request Service.
          Changed visibility from restTemplate in AbstractTest to private and fixed all references in SubClasses. (Revision 1430743)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java
          • /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/UserRequestController.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserRequestTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #417 (See https://builds.apache.org/job/Syncope-trunk/417/ ) SYNCOPE-259 Introduces User Request Service. Changed visibility from restTemplate in AbstractTest to private and fixed all references in SubClasses. (Revision 1430743) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserRequestService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserRequestServiceProxy.java /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/UserRequestController.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserRequestTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #415 (See https://builds.apache.org/job/Syncope-trunk/415/)
          SYNCOPE-259
          Cleanup. Some small refactorings. (Revision 1430250)
          fix typo 9081 SYNCOPE-267 and SYNCOPE-259 (Revision 1430227)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java

          fmartelli :
          Files :

          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/resources/restClientContext.xml
          Show
          Hudson added a comment - Integrated in Syncope-trunk #415 (See https://builds.apache.org/job/Syncope-trunk/415/ ) SYNCOPE-259 Cleanup. Some small refactorings. (Revision 1430250) fix typo 9081 SYNCOPE-267 and SYNCOPE-259 (Revision 1430227) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java fmartelli : Files : /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/resources/restClientContext.xml
          Hide
          Jan Bernhardt added a comment -

          Done. Each REST-Service know has a Service Interface with JAX-RS Annotations and a Proxy Implementation calling old Spring REST-API.

          Next, I'll do the console changes, to also switch using Proxy implementation.

          Show
          Jan Bernhardt added a comment - Done. Each REST-Service know has a Service Interface with JAX-RS Annotations and a Proxy Implementation calling old Spring REST-API. Next, I'll do the console changes, to also switch using Proxy implementation.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #414 (See https://builds.apache.org/job/Syncope-trunk/414/)
          SYNCOPE-259
          Introduces Schema Service. (Revision 1430219)

          Result = UNSTABLE
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/AbstractSchemaTO.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/DerivedSchemaTO.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/SchemaTO.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/VirtualSchemaTO.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          • /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/SchemaController.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java
          • /syncope/trunk/core/src/test/resources/restClientContext.xml
          Show
          Hudson added a comment - Integrated in Syncope-trunk #414 (See https://builds.apache.org/job/Syncope-trunk/414/ ) SYNCOPE-259 Introduces Schema Service. (Revision 1430219) Result = UNSTABLE jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/AbstractSchemaTO.java /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/DerivedSchemaTO.java /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/SchemaTO.java /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/VirtualSchemaTO.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SchemaService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SchemaServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/SchemaController.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/DerivedSchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/VirtualSchemaTestITCase.java /syncope/trunk/core/src/test/resources/restClientContext.xml
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #413 (See https://builds.apache.org/job/Syncope-trunk/413/)
          SYNCOPE-259
          Introduces Notification Service.
          Refactoring proxy services into proxy sub-package. (Revision 1430170)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/NotificationService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/NotificationTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #413 (See https://builds.apache.org/job/Syncope-trunk/413/ ) SYNCOPE-259 Introduces Notification Service. Refactoring proxy services into proxy sub-package. (Revision 1430170) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/NotificationService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/LoggerServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/NotificationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/PolicyServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/UserServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/proxy/WorkflowServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/NotificationTestITCase.java
          Hide
          Jan Bernhardt added a comment -

          Workflow- and NotifificationService are also done. Only Schema-Services are missing. I'll take care for these next.

          Show
          Jan Bernhardt added a comment - Workflow- and NotifificationService are also done. Only Schema-Services are missing. I'll take care for these next.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #411 (See https://builds.apache.org/job/Syncope-trunk/411/)
          SYNCOPE-259
          Introduces Workflow Service.
          Test Case needs to be extended to be of real value! (Revision 1429889)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/WorkflowTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #411 (See https://builds.apache.org/job/Syncope-trunk/411/ ) SYNCOPE-259 Introduces Workflow Service. Test Case needs to be extended to be of real value! (Revision 1429889) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/WorkflowServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/WorkflowTestITCase.java
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #409 (See https://builds.apache.org/job/Syncope-trunk/409/)
          SYNCOPE-259
          Introduces Policy Service
          Updates in UserTestITCase to only use new Service Interfaces. (Revision 1429839)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #409 (See https://builds.apache.org/job/Syncope-trunk/409/ ) SYNCOPE-259 Introduces Policy Service Updates in UserTestITCase to only use new Service Interfaces. (Revision 1429839) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/PolicyServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/PolicyTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Hide
          Jan Bernhardt added a comment -

          Thanks Andrei. I verified your patch and it looks good to me. I already pushed your Service Interface to trunk as well as a new Task Service. I will take care for the Workflow Controller next.

          Show
          Jan Bernhardt added a comment - Thanks Andrei. I verified your patch and it looks good to me. I already pushed your Service Interface to trunk as well as a new Task Service. I will take care for the Workflow Controller next.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #408 (See https://builds.apache.org/job/Syncope-trunk/408/)
          SYNCOPE-259
          Introduces Task Service
          Minor updates to other REST Services. (Revision 1429781)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ResourceTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #408 (See https://builds.apache.org/job/Syncope-trunk/408/ ) SYNCOPE-259 Introduces Task Service Minor updates to other REST Services. (Revision 1429781) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/TaskServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ResourceTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java
          Hide
          Andrei Shakirin added a comment -

          PolicyService patch.
          Essential changes:
          1) generic create and update operations
          2) delete is mapped to HTTP @DELETE instead @GET

          Show
          Andrei Shakirin added a comment - PolicyService patch. Essential changes: 1) generic create and update operations 2) delete is mapped to HTTP @DELETE instead @GET
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #405 (See https://builds.apache.org/job/Syncope-trunk/405/)
          SYNCOPE-259
          Introduces ResourceService and loggerService.
          Minor updates to other REST Services. (Revision 1428905)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConfigurationTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConnInstanceTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ReportTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ResourceTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #405 (See https://builds.apache.org/job/Syncope-trunk/405/ ) SYNCOPE-259 Introduces ResourceService and loggerService. Minor updates to other REST Services. (Revision 1428905) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ReportServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ResourceServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConfigurationTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConnInstanceTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ReportTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ResourceTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          Hide
          Andrei Shakirin added a comment -

          @Jan: I see your point. Let leave it POST for now. "Best practice" solution will be sending only Resource Id for validation and use GET, but in this case Resource object must always be persisted before validation (I am not 100% sure that it is acceptable).

          Show
          Andrei Shakirin added a comment - @Jan: I see your point. Let leave it POST for now. "Best practice" solution will be sending only Resource Id for validation and use GET, but in this case Resource object must always be persisted before validation (I am not 100% sure that it is acceptable).
          Hide
          Jan Bernhardt added a comment -

          ResourceService and LoggerService are done and committed. I'll take Task Service next.

          @Andrei I would prefer GET in general, but code looks to me, that resource properties are taken from POST Body for connection check. You could not send these properties with a GET request. (See Line 242 in org.apache.syncope.core.rest.data.ResourceDataBinder)

          Show
          Jan Bernhardt added a comment - ResourceService and LoggerService are done and committed. I'll take Task Service next. @Andrei I would prefer GET in general, but code looks to me, that resource properties are taken from POST Body for connection check. You could not send these properties with a GET request. (See Line 242 in org.apache.syncope.core.rest.data.ResourceDataBinder)
          Hide
          Andrei Shakirin added a comment -

          It helps! Now I can edit!

          Show
          Andrei Shakirin added a comment - It helps! Now I can edit!
          Hide
          Francesco Chicchiriccò added a comment -

          Andrei, I've given your user some more karma: could you please try again?

          Show
          Francesco Chicchiriccò added a comment - Andrei, I've given your user some more karma: could you please try again?
          Hide
          Andrei Shakirin added a comment -

          Thanks Francesco. I see my name in permission list for edit in page restrictions, but Edit button still doesn't appear on the page. Relogin doesn't help. Any ideas? Or I should just wait a little bit?

          Show
          Andrei Shakirin added a comment - Thanks Francesco. I see my name in permission list for edit in page restrictions, but Edit button still doesn't appear on the page. Relogin doesn't help. Any ideas? Or I should just wait a little bit?
          Hide
          Francesco Chicchiriccò added a comment -

          Jan Bernhardt: I've just given access to the above mentioned wiki page to Andrei Shakirin

          Show
          Francesco Chicchiriccò added a comment - Jan Bernhardt : I've just given access to the above mentioned wiki page to Andrei Shakirin
          Hide
          Andrei Shakirin added a comment -

          Hi Jan,

          Why do you think @GET is not appropriate for this operation? It is idempotent and safe (there is not any modifications in resource status). As far as I can see implementation not only validates arguments, but tries to establish (or check) physical connection to backend.
          For me GET /resources/

          {resourcename}

          /connectorStatus exactly reflects operation semantic. Am I wrong?

          Show
          Andrei Shakirin added a comment - Hi Jan, Why do you think @GET is not appropriate for this operation? It is idempotent and safe (there is not any modifications in resource status). As far as I can see implementation not only validates arguments, but tries to establish (or check) physical connection to backend. For me GET /resources/ {resourcename} /connectorStatus exactly reflects operation semantic. Am I wrong?
          Hide
          Jan Bernhardt added a comment -

          I just took another look at the check/validate method in ResourceService and ConnectorService. And both implementations check if provided argument is sufficient to establish a test connection.

          This means you cannot use @GET but rather @POST. I also fixed this now in ResourceService. Would you agree that in this case validate is more appropriate than check?

          Show
          Jan Bernhardt added a comment - I just took another look at the check/validate method in ResourceService and ConnectorService. And both implementations check if provided argument is sufficient to establish a test connection. This means you cannot use @GET but rather @POST. I also fixed this now in ResourceService. Would you agree that in this case validate is more appropriate than check?
          Hide
          Jan Bernhardt added a comment - - edited

          Hi Andrei,

          +1 for roles,users and configurations. I think Logger is already plural.

          OK, I see your point for validate. Actually according to RESTfull best practices, a URI should not contain action words, but rather states, so something like "/resources/

          {resourcename}

          /connectionStatus" would be more preferable.

          Show
          Jan Bernhardt added a comment - - edited Hi Andrei, +1 for roles,users and configurations. I think Logger is already plural. OK, I see your point for validate. Actually according to RESTfull best practices, a URI should not contain action words, but rather states, so something like "/resources/ {resourcename} /connectionStatus" would be more preferable.
          Hide
          Andrei Shakirin added a comment -

          Hi Jan,

          Thanks, looks perfect now.
          (3): make sense to rename all paths of other services too: e.g. "roles", "users", "loggers", "configurations", etc?
          (4): as far as check verifies connection (LDAP, DB, WS, etc) I personally find names "verify" or "check" better as "validate". Validate IMO related more to argument validity.

          Show
          Andrei Shakirin added a comment - Hi Jan, Thanks, looks perfect now. (3): make sense to rename all paths of other services too: e.g. "roles", "users", "loggers", "configurations", etc? (4): as far as check verifies connection (LDAP, DB, WS, etc) I personally find names "verify" or "check" better as "validate". Validate IMO related more to argument validity.
          Hide
          Jan Bernhardt added a comment - - edited

          Hi Andrei, thanks for your patch! Looks very good in general.

          Could you please also document the REST API changes for your patch here: https://cwiki.apache.org/confluence/display/SYNCOPE/REST+API+upgrade

          @Francesco Could you please provide read/write access to: ashakirin

          Here are a couple of (minor) thinks that I have changed:

          Inside Service Interface:
          1. Applied your previous comment and removed "public" as it is redundant in interface declarations
          2. Removed leading slash "/" in @Path annotations, as it is also redundant (see JavaDoc samples: http://docs.oracle.com/javaee/6/api/javax/ws/rs/Path.html )
          2.1 Removed @Path("/") annotations as they are also redundant
          3. renamed @Path("/resource") interface path to @Path("resources"), as service paths should be in plural (according to best practices)
          4. renamed @Path("check") to @Path("validate")
          5. renamed getObject(..) method to getConnector(..)

          Inside Proxy:
          1. Instead of suppressing a warning, I changed the getPropagationActionsClasses() method to use Array -> List -> Set mappings

          Show
          Jan Bernhardt added a comment - - edited Hi Andrei, thanks for your patch! Looks very good in general. Could you please also document the REST API changes for your patch here: https://cwiki.apache.org/confluence/display/SYNCOPE/REST+API+upgrade @Francesco Could you please provide read/write access to: ashakirin Here are a couple of (minor) thinks that I have changed: Inside Service Interface: 1. Applied your previous comment and removed "public" as it is redundant in interface declarations 2. Removed leading slash "/" in @Path annotations, as it is also redundant (see JavaDoc samples: http://docs.oracle.com/javaee/6/api/javax/ws/rs/Path.html ) 2.1 Removed @Path("/") annotations as they are also redundant 3. renamed @Path("/resource") interface path to @Path("resources"), as service paths should be in plural (according to best practices) 4. renamed @Path("check") to @Path("validate") 5. renamed getObject(..) method to getConnector(..) Inside Proxy: 1. Instead of suppressing a warning, I changed the getPropagationActionsClasses() method to use Array -> List -> Set mappings
          Hide
          Andrei Shakirin added a comment -

          Recreated ResourceService patch for last trunk revision

          Show
          Andrei Shakirin added a comment - Recreated ResourceService patch for last trunk revision
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #401 (See https://builds.apache.org/job/Syncope-trunk/401/)
          SYNCOPE-259
          Introduces LoggerService (Revision 1428465)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/LoggerTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #401 (See https://builds.apache.org/job/Syncope-trunk/401/ ) SYNCOPE-259 Introduces LoggerService (Revision 1428465) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/LoggerServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/LoggerTestITCase.java
          Hide
          Andrei Shakirin added a comment -
          • check: ah, now I see it. Then I would propose to leave check() in ResourceService for now.
          Show
          Andrei Shakirin added a comment - check: ah, now I see it. Then I would propose to leave check() in ResourceService for now.
          Hide
          Francesco Chicchiriccò added a comment -
          • (1) and (2), thanks for reporting Jan! I guess this is solved, then.
          • check(): ResourceTO is passed to ResourceDataBinder#getConnInstance(ResourceTO) which invokes getConnectorId() and getConnConfProperties()
          Show
          Francesco Chicchiriccò added a comment - (1) and (2), thanks for reporting Jan! I guess this is solved, then. check(): ResourceTO is passed to ResourceDataBinder#getConnInstance(ResourceTO) which invokes getConnectorId() and getConnConfProperties()
          Hide
          Jan Bernhardt added a comment -

          You can return an object for HTTP DELETE operation (get is not required). See: http://stackoverflow.com/questions/6581285/is-a-response-body-allowed-for-a-http-delete-request

          According to RESTfull best practices GET operations should be idempotent and should not modify an object. That's why you should use DELETE instead of GET for deleting a resource.

          Show
          Jan Bernhardt added a comment - You can return an object for HTTP DELETE operation (get is not required). See: http://stackoverflow.com/questions/6581285/is-a-response-body-allowed-for-a-http-delete-request According to RESTfull best practices GET operations should be idempotent and should not modify an object. That's why you should use DELETE instead of GET for deleting a resource.
          Hide
          Andrei Shakirin added a comment -

          Hi Francesco, thanks for fast feedback.

          • (1) and (2) are just JAX-RS annotations, not really used at the moment - all operations in proxy are working as before using old HTTP methods. Anyway, we should think about it on the next step, when JAX-RS CXF will be used. GET HTTP operation should be safe by definition, that is not the case for resource.delete(). Perhaps combination get + delete will be better for this.
          • check() has ResourceTO as argument, but actual implementation uses only resourceTO.getConnectorId() from incoming argument. Perhaps we can just pass connectorID directly to check() operation and move it to ConnInstanceService.
          • getPropagationActionsClasses(): agree to leave it into ResourceService.
          Show
          Andrei Shakirin added a comment - Hi Francesco, thanks for fast feedback. (1) and (2) are just JAX-RS annotations, not really used at the moment - all operations in proxy are working as before using old HTTP methods. Anyway, we should think about it on the next step, when JAX-RS CXF will be used. GET HTTP operation should be safe by definition, that is not the case for resource.delete(). Perhaps combination get + delete will be better for this. check() has ResourceTO as argument, but actual implementation uses only resourceTO.getConnectorId() from incoming argument. Perhaps we can just pass connectorID directly to check() operation and move it to ConnInstanceService. getPropagationActionsClasses(): agree to leave it into ResourceService.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #399 (See https://builds.apache.org/job/Syncope-trunk/399/)
          SYNCOPE-259
          Introduces ConnectionService (Revision 1428391)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConnInstanceTestITCase.java
          Show
          Hudson added a comment - Integrated in Syncope-trunk #399 (See https://builds.apache.org/job/Syncope-trunk/399/ ) SYNCOPE-259 Introduces ConnectionService (Revision 1428391) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConnectorServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConnInstanceTestITCase.java
          Hide
          Francesco Chicchiriccò added a comment -

          Andrei, some items as per your latest comment:

          (1) and (2) please be sure that new HTTP methods still comply with operation requirements: for example, delete() was GET and not DELETE because we need to return the deleted object

          • check() takes a ResourceTO argument, so I am actually +-0 to move it to ConnInstanceService
          • getPropagationActionsClasses() is used by the admin console during resource CRUD
          Show
          Francesco Chicchiriccò added a comment - Andrei, some items as per your latest comment: (1) and (2) please be sure that new HTTP methods still comply with operation requirements: for example, delete() was GET and not DELETE because we need to return the deleted object check() takes a ResourceTO argument, so I am actually +-0 to move it to ConnInstanceService getPropagationActionsClasses() is used by the admin console during resource CRUD
          Hide
          Andrei Shakirin added a comment -

          Added patch for ResourceService.
          Essential changes in JAX-RS annotations:
          1) update. Operation is mapped to HTTP put instead post (as far as I can see update is idempotent); resourceName is added to URL - it allows also rename resource
          2) delete. Operation is mapped to HTTP delete instead get.
          3) check. Operation is mapped to HTTP get as far as it is save and idempotent

          Two operations check() and getPropagationActionsClasses() seems not to be directly related to resources.

          • check() validates connection instance and for me it is candidate for ConnInstanceService. Actually test for check() operation located in ConnInstancetestITCase.
          • getPropagationActionsClasses() returns list of class names for PROPAGATION_ACTIONS from classloader. Not sure that this operation should be in ResourceService.
            At the moment I leave both operations in ResourceService.
          Show
          Andrei Shakirin added a comment - Added patch for ResourceService. Essential changes in JAX-RS annotations: 1) update. Operation is mapped to HTTP put instead post (as far as I can see update is idempotent); resourceName is added to URL - it allows also rename resource 2) delete. Operation is mapped to HTTP delete instead get. 3) check. Operation is mapped to HTTP get as far as it is save and idempotent Two operations check() and getPropagationActionsClasses() seems not to be directly related to resources. check() validates connection instance and for me it is candidate for ConnInstanceService. Actually test for check() operation located in ConnInstancetestITCase. getPropagationActionsClasses() returns list of class names for PROPAGATION_ACTIONS from classloader. Not sure that this operation should be in ResourceService. At the moment I leave both operations in ResourceService.
          Hide
          Hudson added a comment -

          Integrated in Syncope-trunk #398 (See https://builds.apache.org/job/Syncope-trunk/398/)
          SYNCOPE-259
          Introduces ConfigurationService Interface (Revision 1428273)
          SYNCOPE-259
          Introduces EntitlementService Interface and EntitlementServiceProxy which is used in Integration-Tests (Revision 1427850)
          SYNCOPE-259
          Introduces RoleService Interface and RoleServiceProxy which is used for Integration-Tests (Revision 1427826)
          SYNCOPE-259
          Applied patch from Christian and added User Search Methods & Tests (Revision 1427749)

          Result = SUCCESS
          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/ConfigurationController.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConfigurationTestITCase.java

          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/EntitlementTO.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java

          jbernhardt :
          Files :

          • /syncope/trunk/client/src/main/java/org/apache/syncope/client/mod/StatusMod.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SearchTestITCase.java

          jbernhardt :
          Files :

          • /syncope/trunk/client/pom.xml
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java
          • /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java
          • /syncope/trunk/core
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SearchTestITCase.java
          • /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java
          • /syncope/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in Syncope-trunk #398 (See https://builds.apache.org/job/Syncope-trunk/398/ ) SYNCOPE-259 Introduces ConfigurationService Interface (Revision 1428273) SYNCOPE-259 Introduces EntitlementService Interface and EntitlementServiceProxy which is used in Integration-Tests (Revision 1427850) SYNCOPE-259 Introduces RoleService Interface and RoleServiceProxy which is used for Integration-Tests (Revision 1427826) SYNCOPE-259 Applied patch from Christian and added User Search Methods & Tests (Revision 1427749) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/ConfigurationServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/controller/ConfigurationController.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/ConfigurationTestITCase.java jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/client/to/EntitlementTO.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/EntitlementServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/SpringServiceProxy.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AuthenticationTestITCase.java jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/client/mod/StatusMod.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/RoleServiceProxy.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SearchTestITCase.java jbernhardt : Files : /syncope/trunk/client/pom.xml /syncope/trunk/client/src/main/java/org/apache/syncope/services /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserService.java /syncope/trunk/client/src/main/java/org/apache/syncope/services/UserServiceProxy.java /syncope/trunk/core /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/SearchTestITCase.java /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java /syncope/trunk/pom.xml
          Hide
          Jan Bernhardt added a comment -

          I agree. I modified my code completion settings in eclipse, to avoid this in the future.

          Show
          Jan Bernhardt added a comment - I agree. I modified my code completion settings in eclipse, to avoid this in the future.
          Hide
          Andrei Shakirin added a comment -

          Jan, just small finding: "public abstract" declarations are redundant in EntitlementService.

          Show
          Andrei Shakirin added a comment - Jan, just small finding: "public abstract" declarations are redundant in EntitlementService.
          Hide
          Jan Bernhardt added a comment -

          OK, Entitlement Service and Configuration Service are done. I'll take ConnInstanceController and LoggerController next.

          Show
          Jan Bernhardt added a comment - OK, Entitlement Service and Configuration Service are done. I'll take ConnInstanceController and LoggerController next.
          Hide
          Andrei Shakirin added a comment -

          I will start with ResourceController (ResourceService) today

          Show
          Andrei Shakirin added a comment - I will start with ResourceController (ResourceService) today
          Hide
          Francesco Chicchiriccò added a comment -

          Ah, now I get it! You want to add searchCount() and paginatedSearch() for roles as well: +1 for this.
          Please refer to SYNCOPE-44 when adding such test methods, thanks.

          Show
          Francesco Chicchiriccò added a comment - Ah, now I get it! You want to add searchCount() and paginatedSearch() for roles as well: +1 for this. Please refer to SYNCOPE-44 when adding such test methods, thanks.
          Hide
          Jan Bernhardt added a comment -

          Thanks. I saw this TestClass, but in this TestClass there are only test like searchCount() and paginatedSearch() for user searches. Something equivalent for roles searches is missing.

          Show
          Jan Bernhardt added a comment - Thanks. I saw this TestClass, but in this TestClass there are only test like searchCount() and paginatedSearch() for user searches. Something equivalent for roles searches is missing.
          Hide
          Francesco Chicchiriccò added a comment -

          About role (and user) search tests, take a look at SearchTestITCase.
          Great to see these progresses about CXF transition, though, nice work!

          Show
          Francesco Chicchiriccò added a comment - About role (and user) search tests, take a look at SearchTestITCase. Great to see these progresses about CXF transition, though, nice work!
          Hide
          Jan Bernhardt added a comment -

          OK, RoleService is also done.
          I noticed that the current Role IT Test coverage is not complete. Role Search (count, page/size) and Role children are not tested. Should I create a JIRA ticket for this?

          Next I'll take care of AuthenticationController -> EntitlementService and ConfigurationController -> ConfigurationService.

          Show
          Jan Bernhardt added a comment - OK, RoleService is also done. I noticed that the current Role IT Test coverage is not complete. Role Search (count, page/size) and Role children are not tested. Should I create a JIRA ticket for this? Next I'll take care of AuthenticationController -> EntitlementService and ConfigurationController -> ConfigurationService.
          Hide
          Jan Bernhardt added a comment -

          Next, I'll do the same for RoleService. If anyone else also likes to prepare another Service Interface, please make a post to this Ticket, to avoid duplicated work.

          Show
          Jan Bernhardt added a comment - Next, I'll do the same for RoleService. If anyone else also likes to prepare another Service Interface, please make a post to this Ticket, to avoid duplicated work.
          Hide
          Jan Bernhardt added a comment - - edited

          OK, I tested the provided patch. Looks good for most parts (thanks to Christian). Here is what I additionally did:

          1. Moved Version from client pom.xml file to parent pom file, since all version numbers are managed in syncopes (root) parent pom file.

          2. Added Deprecated Annotations to Service methods that should be moved or replaced once CXF migration is complete

          3. Added Search Operations to Interface & implemented these new methods in UserServiceProxy

          4. Updated SearchTestITCase to also use UserServiceProxy

          I was able to run: "mvn clean install" without any exceptions.

          Show
          Jan Bernhardt added a comment - - edited OK, I tested the provided patch. Looks good for most parts (thanks to Christian). Here is what I additionally did: 1. Moved Version from client pom.xml file to parent pom file, since all version numbers are managed in syncopes (root) parent pom file. 2. Added Deprecated Annotations to Service methods that should be moved or replaced once CXF migration is complete 3. Added Search Operations to Interface & implemented these new methods in UserServiceProxy 4. Updated SearchTestITCase to also use UserServiceProxy I was able to run: "mvn clean install" without any exceptions.
          Hide
          Jan Bernhardt added a comment -

          Hi Christian, you can provide a patch for each service but, please don't create a new JIRA entry for each service. Only use this JIRA entry for all patches. Francesco already update this JIRA entry title. Thanks!

          Show
          Jan Bernhardt added a comment - Hi Christian, you can provide a patch for each service but, please don't create a new JIRA entry for each service. Only use this JIRA entry for all patches. Francesco already update this JIRA entry title. Thanks!
          Hide
          Francesco Chicchiriccò added a comment -

          Ok, if you are more comfortable this way, provide several patches, then.

          Show
          Francesco Chicchiriccò added a comment - Ok, if you are more comfortable this way, provide several patches, then.
          Hide
          Christian Schneider added a comment -

          We could do the change in one issue but I prefer to do it in small steps. As we are not really changing the service implementation I think we can change each Service separately.

          Show
          Christian Schneider added a comment - We could do the change in one issue but I prefer to do it in small steps. As we are not really changing the service implementation I think we can change each Service separately.
          Hide
          Francesco Chicchiriccò added a comment -

          Why this issue is limited to UserService only? Shouldn't cover all services (RoleService, SchemaService, ....) at once?

          Show
          Francesco Chicchiriccò added a comment - Why this issue is limited to UserService only? Shouldn't cover all services (RoleService, SchemaService, ....) at once?
          Hide
          Christian Schneider added a comment -

          Added patch to introduce the UserService interface and switch the UserTestITCase to it.

          Show
          Christian Schneider added a comment - Added patch to introduce the UserService interface and switch the UserTestITCase to it.

            People

            • Assignee:
              Jan Bernhardt
              Reporter:
              Christian Schneider
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development