[SYNCOPE-219] Changing attributes of inactive users

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.0.1-incubating
• Component/s: core
• Assignee: Francesco Chicchiriccò
• Reporter: Jan Bernhardt
• Created: 09/Oct/12 15:44
• Updated: 12/Nov/12 12:16
• Resolved: 12/Nov/12 11:16

Description

I attached a visual representation of a modified workflow allows changing of attributes of suspended users (relied to [1]). I also attached a modified BPMN workflow for this purpose.

After applying this workflow to my syncope instance I’ve got the effect, that users will be set active after any user updates. The attention was to be able of changing inactive (suspended) user attributes while these users remain inactive. I believe that the root cause for this behavior is that an attribute “enabled” is checked (Line 80) which is not set at this point. Why is this attribute (enabled) used instead of ${syncopeUser. getSuspended()} ? If the second case would be true, this should solve the current issue and then there would be no need for the AutoActivate serviceTask…

In my opinion it should be possible to change attributes of suspended users by default. So my proposal would be to deliver my modified version with the standard installation of syncope.

I also changed the naming in the workflow whenever possible without effecting the implementation to distinct between user workflows and other (e.g. roles, see SYNCOPE-173). My suggestion would be to move (refactor) all user workflow serviceTasks from “org.apache.syncope.core.workflow.activiti” to “org.apache.syncope.core.workflow.activiti.user”. By doing so it will be easier for SYNCOPE-173 to add role serviceTasks.

[1] http://syncope-user.1051894.n5.nabble.com/Issue-with-importing-suspended-user-td5706694.html

Issue Links

• is related to: SYNCOPE-173 Role workflow