[SYNCOPE-217] SyncopeUser.hasTokenExpired() can easily cause nullpointer exception

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.2-incubating
• Fix Version/s: 1.0.3-incubating, 1.1.0
• Component/s: core
• Assignee: Francesco Chicchiriccò
• Reporter: Jan Bernhardt
• Created: 09/Oct/12 12:59
• Updated: 30/Oct/12 10:56
• Resolved: 09/Oct/12 16:00

Description

public boolean hasTokenExpired() {
return tokenExpireTime.before(new Date());
}

should be changed to:

public boolean hasTokenExpired() {
return tokenExpireTime == null
? false
: tokenExpireTime.before(new Date());
}

A token set to null should never expire to be consistent with the behavior that a token will always be vaild valid (in checkToken method) if it is null.