[SYNAPSE-907] VFSTransportListener locks a folder if a non-matching file is put in to it

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 3.0.0
• Component/s: Transports
• Labels: lock vfs
• Environment: I have tried this with a ftp/sftp location
• Assignee: Hiranya Kasub Jayathilaka
• Reporter: Amila Maharachchi
• Created: 19/Aug/12 07:34
• Updated: 17/Aug/13 19:05
• Resolved: 18/Jul/13 18:25

Description

Create a VFS proxy, provide a file name pattern and a file uri to listen in. Then put a file with a non-matching file name patter to the mentioned folder. VFSTransportListener locks the folder without checking whether the file pattern matches and this lock is not released. After that even if we put a correct file, it cannot be processed due to the lock.

Following code segment is the culprit.

VFSTransportListener#scanFileOrDirectory

else if (!(!entry.isFileLockingEnabled() || (entry.isFileLockingEnabled()
&& VFSUtils.acquireLock(fsManager, fileObject))) &&
log.isDebugEnabled())

{ log.debug("Couldn't get the lock for processing the file : " + child.getName()); }

this passes the wrong fileobject to acquire the lock (this should pass child intead of the fileObject). Even we fix this place, this logic is wrong. We dont need to acquire a lock for a non-matching file.

I have rectified the logic and I'll provide a patch for this.