[SVN-780] Check printf return values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: all
• Fix Version/s: unscheduled
• Component/s: src
• Labels: bite-sized

Environment

other

• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 03/Jul/02 20:51
• Updated: 27/Oct/18 16:38
• Resolved: 05/Oct/05 16:48

Description

Functions like printf can fail. Subversion should not just ignore the
return value and continue. The log command in the svn client uses
printf without any checks. The function apr_file_printf is similar to
printf. The diff command in libsvn_client uses apr_file_printf without
any checks.

Some of these could use svn_io_file_printf but be aware that this will
allocate memory for a sprintf first. Some should use apr_file_puts or
apr_file_write directly.

Issue Links

• blocks: SVN-1537 on win32, use wide-char functions for console i/o to reduce data loss
• is depended upon by: SVN-1537 on win32, use wide-char functions for console i/o to reduce data loss