[SVN-4914] svn client crashes with assert instead of reporting an error

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.13.0
• Component/s: svn++

Environment

svn, version 1.13.0 (r1867053)
compiled May 12 2022, 20:47:08 on x86_64-pc-linux-gnu

• Assignee: Unassigned
• Reporter: Sebb
• Created: 19/Apr/23 23:25
• Updated: 19/Apr/23 23:25

Description

I've seen some crashes in SVN where the target does not have the expected type.

For example:

$ svn info https://www.apache.org/foundation/records/990-2016.pdf
svn: E235000: In file
'/build/subversion-owKwd0/subversion-1.13.0/subversion/libsvn_client/util.c'
line 96: assertion failed
(svn_uri__is_ancestor(pathrev->repos_root_url, url))
Aborted (core dumped)

$ svn pl -v https://dist.apache.org/repos/dist/dev/whimsy/test.txt
Properties on 'https://dist.apache.org/repos/dist/dev/whimsy/test.txt':
svn:eol-style
native

$ svn ps svn:mime-type text/plain
https://dist.apache.org/repos/dist/dev/whimsy/test.txt
svn: E235000: In file
'/build/subversion-owKwd0/subversion-1.13.0/subversion/libsvn_subr/dirent_uri.c'
line 1634: assertion failed (! svn_path_is_url(relative))
Aborted (core dumped)

$ svn --version
svn, version 1.13.0 (r1867053)
compiled May 12 2022, 20:47:08 on x86_64-pc-linux-gnu

Whilst these are invalid usages, I don't believe they should crash
with an assertion.