Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4811

Test failures with Python 3

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.11.0
    • 1.14.0
    • tests

    Description

      Running the test suite with Python 3 causes failures in svnadmin_tests.py 69 and tree_conflict_tests.py 26 (both new in 1.11):

       W: CWD: /tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline
      Traceback (most recent call last):
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/main.py", line 1894, in run
          rc = self.pred.run(sandbox)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/testcase.py", line 178, in run
          result = self.func(sandbox)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svnadmin_tests.py", line 3861, in dump_no_canonicalize_svndate
          assert propval + '\n' in dump_lines
      AssertionError
      FAIL: svnadmin_tests.py 69: svnadmin dump shouldn't canonicalize svn:date
      
      W: A1/B/lambda has unexpectected contents
      W: EXPECTED svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda (match_all=True):
      W: | This is the file 'lambda'.
      W: | This is more content.
      W: ACTUAL svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda:
      W: CWD: /tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline
      Traceback (most recent call last):
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/main.py", line 1894, in run                                                                        
          rc = self.pred.run(sandbox)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/testcase.py", line 178, in run                                                                     
          result = self.func(sandbox)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/tree_conflict_tests.py", line 1547, in local_missing_dir_endless_loop                                      
          [ "This is the file 'lambda'.\n", "This is more content.\n"], contents)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py", line 503, in compare_and_display_lines                                                 
          expected.display_differences(message, label, actual)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py", line 154, in display_differences
          display_lines(message, self.expected, actual, e_label, label)
        File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py", line 478, in display_lines
          logger.warn('| ' + x.rstrip())
      TypeError: can only concatenate str (not "bytes") to str
      FAIL:  tree_conflict_tests.py 26: endless loop when resolving local-missing dir
      END: tree_conflict_tests.py
      ELAPSED: tree_conflict_tests.py 0:01:17.563191
      

      Is it safe to ignore these failures, or should users stick with Python 2 for now?

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            mbakke Marius
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment