[SVN-4764] subversion-1.10.2/subversion/bindings/javahl/native/JNIUtil.cpp:589]: (error) Dangerous usage of c_str()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: bindings_javahl
• Assignee: Branko Čibej
• Reporter: David Binderman
• Created: 22/Jul/18 10:01
• Updated: 27/Jul/18 13:01
• Resolved: 27/Jul/18 13:01

Description

subversion-1.10.2/subversion/bindings/javahl/native/JNIUtil.cpp:589]: (error) Dangerous usage of c_str(). The value returned by c_str() is invalid after this call.

 

Source code is

{ std::ostringstream buf; buf << err->file; if (err->line > 0) buf << ':' << err->line; source = buf.str().c_str(); }

 

source is left pointing at a random stack location.