Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4660

svn info --show-item=revision produces trailing whitespace

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.9.4
    • 1.9.5, trunk
    • cmdline client
    • None

    Description

      Steps to reproduce:
      1. Run svn info --show-item=revision >out.txt

      Expected result:
      The file out.txt contains just the revision number and a newline.

      Actual result:
      The file out.txt contains the revision number, followed by some whitespaces and a newline.

      The issue was passed on to the dev list here: http://mail-archives.apache.org/mod_mbox/subversion-dev/201610.mbox/%3C20161028184002.GA25363%40fujitsu.shahaf.local2%3E

      Rational for this being a bug/unintended behavior:
      1. One (if not the) main use-case for the newly introduced --show-item option is to make it easier to be used in scripts. For revisions, I used that to generate a revision range as in: -rXXX:YYY. XXX was retrieved using --show-item=revision. Since that produced unexpected trailing whitespaces the script command resulted in [...] -rXXX :YYY [...] which obviously caused an error message which was hard to debug since I didn't immediately get the idea that the trailing whitespaces might cause the script error I saw.
      2. It's not what the documentation in the release notes state:
      https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item
      where it's explicitly shown that the reported revision number does not have any trailing whitespace:

      ## Display the youngest revision of a repository:
      % svn info --show-item=revision https://svn.apache.org/repos/asf/subversion/trunk
      1693514
      
      ## Find the root directory of a working copy:
      % svn info --show-item=wc-root
      /home/jrandom/src/svn/trunk
      

      Note: The issue was not present in SVN < 1.9, since the --show-item-option was added in SVN 1.9.0. Also I only tested it explicitly with SVN 1.9.4 but since the code change was introduced in 1.9.0 I'm quite certain the behavior exists in SVN 1.9.0-1.9.3 as well.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            luke1410 Stefan Hett
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment