[SVN-4637] Revert affects unchanged files with changed permissions

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.9.3
• Assignee: Unassigned
• Reporter: Johan Corveleyn
• Created: 20/Jun/16 21:29
• Updated: 27/Jun/16 13:24

Description

If you make a file read-only, and run a recursive revert, the file is made writable again, and revert notifies:

C:\Temp\svntest>svnadmin create repos

C:\Temp\svntest>svn co file:///c:/Temp/svntest/repos wc
Checked out revision 0.

C:\Temp\svntest>cd wc

C:\Temp\svntest\wc>echo This is file 1 > file1.txt

C:\Temp\svntest\wc>svn add *.txt
A file1.txt

C:\Temp\svntest\wc>svn ci -mm
Adding file1.txt
Transmitting file data ..done
Committing transaction...
Committed revision 1.

C:\Temp\svntest\wc>attrib +R file1.txt ### (making read-only)

C:\Temp\svntest\wc>svn st

C:\Temp\svntest\wc>svn revert -R .
Reverted 'file1.txt'

After this, the file is writable again.

I think 'revert' should not affect files that have only metadata (like permissions) changed. I'm actually wondering how revert decided to do this, because I thought it acted on the result of a 'status walk', and 'svn status' does not show such a file.

I'm not sure what revert should do with the modified permissions if it's already reverting the content.

See also this post on users@:
http://svn.haxx.se/users/archive-2016-03/0035.shtml

The original post that started the thread:
http://svn.haxx.se/users/archive-2016-03/0004.shtml

OP reported this for Centos 6.5 Linux, so I suppose the issue is not limited to Windows.