[SVN-4612] With Perl module SVN::Client, assertion failure due to non-canonical path

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.9.3
• Component/s: bindings_swig_perl
• Assignee: Unassigned
• Reporter: Vincent Lefevre
• Created: 22/Jan/16 15:47
• Updated: 22/Jan/16 15:52

Description

Various functions assume that the path provided in argument is a canonical path. When the path is not canonical, this triggers an assertion failure in the library:

svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.

While this may be acceptable for C programs, this is not in Perl, where one should get proper error reporting.

Test case with info:

#!/usr/bin/env perl

use strict;
use SVN::Client;

my $svnc = SVN::Client->new;
$svnc->info('.', undef, undef, sub { }, 0);

The Perl module should make sure that the path is canonical before calling the corresponding svn library function (cannot this be automatically generated with swig if the code has some form of precondition that the path needs to be canonical?). It could either canonicalize the path so that the library call succeeds or immediately return an error if the path is not canonical. Alternatively, the svn library function could do path canonicalization itself.