[SVN-4543] Infinite recursion SEGV in config value expansion

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: all
• Fix Version/s: 1.10.0
• Component/s: libsvn_subr
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 20/Dec/14 11:59
• Updated: 27/Oct/18 16:30
• Resolved: 28/Jun/15 17:52

Description

Config value expansion does not detect self-references or loops. Attempting to
expand such a value leads to infinite recursion and a SEGV. Apply the patch
below and run "config-test 9", i.e "test variable expansion":

$ subversion/tests/libsvn_subr/config-test --srcdir
subversion/tests/libsvn_subr/config-test 9
Segmentation fault

Index: ../src/subversion/tests/libsvn_subr/config-test.cfg
===================================================================
--- ../src/subversion/tests/libsvn_subr/config-test.cfg	(revision 1646804)
+++ ../src/subversion/tests/libsvn_subr/config-test.cfg	(working copy)
@@ -35,7 +35,7 @@
 # Expansion format escaping doesn't seem possible
 f=%%(a)s
 # Two-level variable expansion with surrounding text
-g=lyrical %(c)sd
+g=lyrical %(g)sd
 # Unterminated format string
 h=  %(unterminated
 # Multiple expansions