[SVN-4320] fsfs file-hinting fails when reading a rep from the transaction that is commiting rev = SHARD_SIZE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: 1.8.0
• Component/s: libsvn_fs_fs
• Assignee: Ben Reser
• Reporter: Ben Reser
• Created: 15/Feb/13 07:09
• Updated: 27/Oct/18 16:30
• Resolved: 15/Feb/13 07:29

Description

svnlook and svnauthz reading a file from a transaction will fail when the transaction is commiting the 
revision equal to the repositories shard size with this error:
svnauthz: E070014: Can't read file '/home/danielsh/src/svn/t1/subversion/tests/cmdline/svn-test-
work/repositories/svnauthz_tests-10/db/txn-protorevs/3-3.rev': End of file found

You can reproduce this by building SVN with SVN_FS_FS_DEFAULT_MAX_FILES_PER_DIR=4 and running 
the svnauthz_tests.py 10.

The problem is that the current file hinting code does not check that the rev_hint is a valid revnum in 
create_rep_state_body().  When create_rep_state_body() is called to retrieve the transactions 
predecessor, it has a rev_hint of -1 (since the previous representation was the transaction).  -1 / SHARD 
= 0 and (SHARD - 1) / SHARD = 0 so it believes the representation is in the protorev file.