[SVN-4274] serf client hangs when server crashes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: all
• Fix Version/s: 1.8.0
• Component/s: libsvn_ra_serf
• Labels: third-party
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 14/Dec/12 21:51
• Updated: 27/Oct/18 16:29
• Resolved: 20/Jan/13 11:21

Description

Using a server without r1422100 the following causes the server the SEGV:

svnadmin create repo
touch repo/db/rep-cache.db
chmod 0 repo/db/rep-cache.db
svn import -mm repo/format http://localhost:8888/obj/repo/f

The apache error log shows:

[Fri Dec 14 21:46:22 2012] [error] [client ::1] (20014)Internal error: -sqlite:
unable to open database file: '/home/pm/sw/subversion/obj/repo/db/rep-cache.db'
../src/subversion/libsvn_subr/sqlite.c:211: (apr_err=235000)
svn: E235000: In file '../src/subversion/libsvn_subr/sqlite.c' line 211:
assertion failed (stmt_idx < db->nbr_statements)
[Fri Dec 14 21:46:23 2012] [notice] child pid 17638 exit signal Aborted (6)

which is fixed by r1422100. When this crash occurs the client hangs:

(gdb) bt
#0  0x00007ffff66890b3 in __epoll_wait_nocancel ()
    at ../sysdeps/unix/syscall-template.S:82
#1  0x00007ffff6b7af83 in ?? () from /usr/lib/libapr-1.so.0
#2  0x00007ffff6b7ca5f in apr_pollset_poll () from /usr/lib/libapr-1.so.0
#3  0x00007ffff3eed8d8 in serf_context_run ()
   from /usr/local/serf/lib/libserf-1.so.0
#4  0x00007ffff5b1bc27 in svn_ra_serf__context_run_wait (done=0x7ffff7fc3174, 
    sess=0x7ffff7fe5108, scratch_pool=0x7ffff7fb7028)
    at ../src/subversion/libsvn_ra_serf/util.c:741
#5  0x00007ffff5b1be66 in svn_ra_serf__context_run_one (
    handler=0x7ffff7fc3158, scratch_pool=0x7ffff7fb7028)
    at ../src/subversion/libsvn_ra_serf/util.c:811
#6  0x00007ffff5b09edf in svn_ra_serf__run_merge (commit_info=0x7fffffffdec0, 
    response_code=0x7fffffffdebc, session=0x7ffff7fe5108, conn=0x7ffff7fe3638, 
    merge_resource_url=0x7ffff7f758c0
"/obj/repo/!svn/act/25706164-ebc4-4246-946a-1ed072d62e50", lock_tokens=0x0,
keep_locks=1, result_pool=0x7ffff7fb7028, 
    scratch_pool=0x7ffff7fb7028)
    at ../src/subversion/libsvn_ra_serf/merge.c:425
#7  0x00007ffff5b0468d in close_edit (edit_baton=0x7ffff7f6f980, 
    pool=0x7ffff7fb7028) at ../src/subversion/libsvn_ra_serf/commit.c:2160
#8  0x00007ffff7b936c9 in import (
    local_abspath=0x7ffff7f6ad88 "/home/pm/sw/subversion/obj/reconfig", 
    new_entries=0x7ffff7f6ac60, editor=0x7ffff7f6fcf0, 
    edit_baton=0x7ffff7f6f980, depth=svn_depth_infinity, 
    excludes=0x7ffff7f6ab90, autoprops=0x7ffff7f6fd98, 
    local_ignores=0x7ffff7f74fc0, global_ignores=0x7ffff7f70120, no_ignore=0, 
    no_autoprops=0, ignore_unknown_node_types=0, filter_callback=0, 
    filter_baton=0x0, ctx=0x7ffff7f69a90, pool=0x7ffff7fb7028)
    at ../src/subversion/libsvn_client/import.c:773
#9  0x00007ffff7b941af in svn_client_import5 (path=0x7ffff7f6aa58 "reconfig", 
    url=0x7ffff7f6f710 "http://localhost:8888/obj/repo", 
    depth=svn_depth_infinity, no_ignore=0, no_autoprops=0, 
    ignore_unknown_node_types=0, revprop_table=0x0, filter_callback=0, 
    filter_baton=0x0, commit_callback=0x4289c4 <svn_cl__print_commit_info>, 
    commit_baton=0x0, ctx=0x7ffff7f69a90, scratch_pool=0x7ffff7feb028)
    at ../src/subversion/libsvn_client/import.c:967
#10 0x00000000004118ac in svn_cl__import (os=0x7ffff7feb280, 
    baton=0x7fffffffe440, pool=0x7ffff7feb028)
    at ../src/subversion/svn/import-cmd.c:115
#11 0x00000000004272b4 in sub_main (argc=5, argv=0x7fffffffe8e8, 
    pool=0x7ffff7feb028) at ../src/subversion/svn/svn.c:2732
#12 0x000000000042749d in main (argc=5, argv=0x7fffffffe8e8)
    at ../src/subversion/svn/svn.c:2787

I'm using serf 1.2.x@1705 and libsvn_ra_serf@r1422099.

https://code.google.com/p/serf/issues/detail?id=94

Issue Links

• blocks: SVN-4296 svn 1.8 blocks on release of serf 1.2.x
• is depended upon by: SVN-4296 svn 1.8 blocks on release of serf 1.2.x