[SVN-4248] Remove NLS check for KWallet support and reorder private includes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ---
• Fix Version/s: 1.8.0
• Component/s: libsvn_auth_kwallet
• Labels: patch
• Assignee: Unassigned
• Reporter: Subversion Importer
• Created: 19/Oct/12 00:09
• Updated: 27/Oct/18 16:30
• Resolved: 10/Apr/13 12:44

Description

Following Daniel's suggestions in previous thread, attached is another iteration 
of the patch that removes the need for NLS to be enabled for KWallet support to 
be built.

Besides removing the NLS check from kwallet.m4 as the previous patch did, this 
one also reorders the includes in kwallet.cpp so that the private Subversion 
includes come after the system/KDE ones. The same has been done to the GNOME 
Keyring code, as well as another file.

In most of the cases, svn_private_config.h is already one of the last files to 
be included, and I felt it was too dangerous to change the cases where it was 
included before some feature checks or apr includes.

http://svn.haxx.se/dev/archive-2012-09/0215.shtml

Original issue reported by gavinbaumanis