[SVN-4208] FSFS cache triggers valgrind warning

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: unscheduled
• Component/s: libsvn_fs_fs
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 25/Jul/12 10:36
• Updated: 27/Oct/18 16:30
• Resolved: 21/Feb/13 16:26

Description

svnadmin create repo
svn import -mm repo/format file://`pwd`/repo/f
svnadmin verify repo

* Verified revision 0.
==9089== Invalid read of size 1
==9089==    at 0x4C25FF8: memcpy (mc_replace_strmem.c:497)
==9089==    by 0x54E73F5: svn_stringbuf_appendbytes (string.c:558)
==9089==    by 0x54ECEDC: svn_temp_serializer__push (temp_serializer.c:245)
==9089==    by 0x61132C0: serialize_svn_string (temp_serializer.c:130)
==9089==    by 0x6113BDA: serialize_txdeltawindow (temp_serializer.c:479)
==9089==    by 0x6113C70: svn_fs_fs__serialize_txdelta_window
(temp_serializer.c:505)
==9089==    by 0x54B010B: membuffer_cache_set (cache-membuffer.c:1241)
==9089==    by 0x54B0AC2: svn_membuffer_cache_set (cache-membuffer.c:1766)
==9089==    by 0x54B2486: svn_cache__set (cache.c:101)
==9089==    by 0x60FCE0B: set_cached_window (fs_fs.c:4417)
==9089==    by 0x60FD5F5: read_window (fs_fs.c:4629)
==9089==    by 0x60FD69C: get_combined_window (fs_fs.c:4655)
==9089==  Address 0x7e7f575 is 0 bytes after a block of size 5 alloc'd
==9089==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==9089==    by 0x59516D0: pool_alloc (apr_pools.c:1463)
==9089==    by 0x5289811: svn_txdelta_read_svndiff_window (svndiff.c:977)
==9089==    by 0x60FD50E: read_window (fs_fs.c:4618)
==9089==    by 0x60FD69C: get_combined_window (fs_fs.c:4655)
==9089==    by 0x60FDC57: get_contents (fs_fs.c:4802)
==9089==    by 0x60FDD22: rep_read_contents (fs_fs.c:4827)
==9089==    by 0x54E306E: svn_stream_read (stream.c:143)
==9089==    by 0x54E3CED: svn_stream_copy3 (stream.c:497)
==9089==    by 0x4E3C9D2: dump_node (dump.c:627)
==9089==    by 0x4E3CF70: add_file (dump.c:789)
==9089==    by 0x527B6F9: add_file (cancel.c:167)