Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Abandoned
-
1.7.x
-
None
-
Linux
Description
Hello all,
I see in the subversion-1.7.2, that ruby versions greater than 1.8 are disabled
for the swig bindings. For the sake of testing, I disabled that check and
regenerated the autoconf 'configure' file, to allow the bindings to be built.
The following is the full diff from the subversion-1.7.2 release tarball.
<patch>
Index: subversion-1.7.2/configure.ac
===================================================================
--- subversion-1.7.2.orig/configure.ac
+++ subversion-1.7.2/configure.ac
@@ -1132,13 +1132,6 @@ if test "$RUBY" != "none"; then
AC_SUBST(RUBY_MAJOR)
AC_SUBST(RUBY_MINOR)
- if test ! \( "$RUBY_MAJOR" -eq "1" -a "$RUBY_MINOR" -eq "8" \); then
- # Disallow Ruby 1.9 or later until the binding tests get fixed
- # to run with those versions.
- RUBY="none"
- AC_MSG_WARN([The detected Ruby is too new for Subversion to use])
- AC_MSG_WARN([Only 1.8.x releases are supported at this time])
- fi
else
AC_MSG_RESULT([no])
RUBY="none"
Index: subversion-1.7.2/configure
===================================================================
--- subversion-1.7.2.orig/configure
+++ subversion-1.7.2/configure
@@ -854,9 +854,7 @@ enable_fast_install
with_gnu_ld
with_sysroot
enable_libtool_lock
-with_gnu_ld
enable_experimental_libtool
-enable_static
enable_all_static
enable_local_library_preloading
with_trang
@@ -884,12 +882,6 @@ with_jikes
with_swig
with_ruby_sitedir
with_ruby_test_verbose
-with_ruby_sitedir
-with_ruby_test_verbose
-with_ruby_sitedir
-with_ruby_test_verbose
-with_ruby_sitedir
-with_ruby_test_verbose
with_ctypesgen
enable_runtime_module_search
enable_javahl
@@ -905,9 +897,6 @@ LIBS
CPPFLAGS
CXX
CXXFLAGS
-LDFLAGS
-LIBS
-CPPFLAGS
CCC
CPP
CXXCPP'
@@ -20885,15 +20874,6 @@ $as_echo "$svn_cv_ruby_minor" >&6; }
- if test ! \( "$RUBY_MAJOR" -eq "1" -a "$RUBY_MINOR" -eq "8" \); then
- # Disallow Ruby 1.9 or later until the binding tests get fixed
- # to run with those versions.
- RUBY="none"
- { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The detected Ruby is
too new for Subversion to use" >&5
-$as_echo "$as_me: WARNING: The detected Ruby is too new for Subversion to use"
>&2;}
- { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Only 1.8.x releases are
supported at this time" >&5
-$as_echo "$as_me: WARNING: Only 1.8.x releases are supported at this time" >&2;}
- fi
else
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
$as_echo "no" >&6; }
</patch>
Now the 'swig-rb' and 'install-swig-rb' Makefile targets build the ruby bindings
successfully on ruby-1.9.3-p0, with the following files:
<files>
./usr/lib64/libsvn_swig_ruby-1.a
./usr/lib64/ruby/site_ruby/1.9.1/svn/info.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/core.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/delta.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/error.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/fs.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/repos.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/wc.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/ra.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/client.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/synchronizer.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/util.rb
./usr/lib64/ruby/site_ruby/1.9.1/svn/commit-mailer.rb
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/diff.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/ra.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/fs.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/delta.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/repos.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/diff.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/client.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/core.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/wc.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/core.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/client.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/repos.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/ra.la
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/wc.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/delta.so
./usr/lib64/ruby/site_ruby/1.9.1/x86_64-linux/svn/ext/fs.la
./usr/lib64/libsvn_swig_ruby-1.la
./usr/lib64/libsvn_swig_ruby-1.so.0.0.0
</files>
As a simple check that the libraries are intact and usable, I ran the following:
<ruby_code>
require 'svn/client'
# => true
ctx = Svn::Client::Context.new
# => #<Svn::Ext::Client::Svn_client_ctx_t:0x00000001292f48>
ctx.checkout('http://svn.apache.org/repos/asf/subversion/trunk','subversion')
# => 1215260
</ruby_code>
Success. Can we enable the build for ruby-1.9.x please?
Thanks for all the good work.
Take care,
vb
Original issue reported by vbatts