[SVN-3764] svn patch opens the patch file too many times

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: 1.7.0
• Component/s: libsvn_diff
• Assignee: Unassigned
• Reporter: Stefan Sperling
• Created: 11/Dec/10 16:06
• Updated: 27/Oct/18 16:28
• Resolved: 08/Jan/11 02:35

Description

svn patch opens the patch file three times for each hunk in the patch.

This means that with a file descriptor limit of 1024, trying to apply a patch
with more than about 341 hunks (a bit less in practice due to other open files)
fails with an error: svn: Can't open file 'test.diff': Too many open files

Since the implementation details of svn_hunk_t are opaque to the patch code in
libsvn_client, it is possible to fix this problem locally within the diff parser
in libsvn_diff/parse-diff.c.