Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-3257

perl 5.10.0 doesn't seem to alow opening in memory to a constant

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.5.x
    • ---
    • bindings_swig_perl

    Description

      perl 5.10 doesn't seem to allow opening in memory to a constant
      
      ../../../../../subversion/bindings/swig/perl/native/t/6ra..............1/40 
      Modification of a read-only value attempted at ../../../../../subversion/
      bindings/swig/perl/native/t/6ra.t line 225.
      error opening in-memory file to store Subversion update: Invalid argument 
      at ../../../../../subversion/bindings/swig/perl/native/t/6ra.t line 225.
      
      Fix:
      
      --- ./subversion/bindings/swig/perl/native/t/6ra.t.org  2008-08-10 
      11:16:08.571581580 +0200
      +++ ./subversion/bindings/swig/perl/native/t/6ra.t      2008-08-10 
      11:18:55.423648224 +0200
      @@ -221,10 +221,12 @@
      
       sub apply_textdelta {
           my ($self, $baton, $base_checksum, $pool) = @_;
      -    my $data = $baton->{data} = \'';
      +    my $mem1;
      +    my $mem2;
      +    my $data = $baton->{data} = \$mem1;
           open my $out_fh, '>', $data
               or die "error opening in-memory file to store Subversion update: $!";
      -    open my $in_fh, '<', \''
      +    open my $in_fh, '<', \$mem2
               or die "error opening in-memory file for delta source: $!";
           return [ SVN::TxDelta::apply($in_fh, $out_fh, undef, "$baton", $pool) ];
       }
      

      Original issue reported by arekm

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              subversion-importer Subversion Importer
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: