[SVN-2906] Invalid diff format under Chinese locale

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.x
• Fix Version/s: ---
• Component/s: libsvn_diff
• Assignee: Unassigned
• Reporter: Subversion Importer
• Created: 03/Sep/07 22:03
• Updated: 27/Oct/18 16:35
• Resolved: 07/Sep/07 09:56

Description

This issue was first reported on the user mailing list:
http://svn.haxx.se/users/archive-2007-08/0427.shtml.

For convenience, here is the text of the message again:

Hi there,

I received a diff file from a Chinese user of Subversion, the relevant
bit is as follows, which is the end of one diff segment, and the start
of another:

#endif
\  $B:_J87o (B
  $BKvHxKWM-?79T (BIndex: src/file.cpp

The Chinese is the translation of "No newline at end of file".

My question is, why does this sentence have a newline in the middle of
it? Also the "Index:" text doesn't start at the beginning of a
newline.

To be properly formatted as a diff, I would have thought this should be:

#endif
\  $B:_J87oKvHxKWM-?79T (B
Index: src/file.cpp

Is this a bug?

This came up, as I am the author of Codestriker, which is a web
application for code reviewing. As input, it can receive diff files
from different SCMs, including Subversion. This diff came up which it
couldn't parse, because of this extra newline.

Cheers,
David

Original issue reported by sits