Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2507

'commit --no-unlock' doesn't remove locks on files deleted

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3.x
    • Fix Version/s: unscheduled
    • Component/s: libsvn_client, libsvn_fs
    • Labels:
      None

      Description

      As reported here:
      http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=433823

      Filing issue with permission of Ben Collins-Sussman:

      When a commit deletes a file, and the --no-unlock option is passed with the commit, the lock is not removed. That leaves a lock on a non-existing file:

      $ svnadmin create lockrepo
      $ svn co file:///d:/test/lockrepo lockwc
      $ cd lockwc
      $ echo test > file
      $ svn add file
      $ svn ci -m ""
      $ svn lock file
      $ svn rm file
      $ svn ci -m "" file --no-unlock
      $ echo test2 > file
      $ svn add file
      $ svn ci -m ""
      Adding           file
      svn: commit failed (details follow):
      svn: Cannot verify lock on path '/file'; no matching lock-token available
      

      I'm not sure if that really intended. Of course, the above recipe isn't that 'real life', but imagine a commit with --no-unlock where not just the removed file but multiple other files are committed too, then the --no-unlock option makes more sense.

      I think in case a file gets removed from the repository, the lock should be removed too, no matter if the --no-unlock option is passed or not.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                steveking Stefan K√ľng
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: