[SVN-2249] svn_io_copy_dir_recursively should copy directory attributes.

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.1.x
• Fix Version/s: nonblocking
• Component/s: libsvn_subr

Environment

Windows 2000

• Assignee: Unassigned
• Reporter: C. Michael Pilato
• Created: 15/Mar/05 14:45
• Updated: 31/Mar/05 20:07

Description

On Windows systems, 'svn copy dir1 dir2' will result in a dir2 which has its
.svn folder lacking the HIDDEN attribute.  I tracked this down to
svn_io_copy_dir_recursively, which has this very revealing comment:

  /* Create the new directory. */
  /* ### TODO: copy permissions? */
  SVN_ERR (svn_io_dir_make (dst_path, APR_OS_DEFAULT, pool));

To answer the question posed, "Yes.  We should be copying permissions."  But
even if we don't copy all the permissions, can we at least handle directories
whose basename is ".svn" by calling svn_io_dir_make_hidden() on their copies?

Issue Links

• is duplicated by: SVN-1739 win32 dir creation should preserve perms