Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2147

Control characters in log message cause failure

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • 1.3.0
    • mod_dav_svn

    Description

      mod_dav_svn (or libsvn_ra_dav) isn't properly escaping the control characters of
      a log message.  The client will not normally submit them, but a subversion dump
      load might contain control characters.
      
      % svn log -r102002 http://svn.apache.org/repos/asf
      svn: REPORT request failed on '/repos/asf/!svn/bc/102002'
      svn: The REPORT request returned invalid XML in the response: XML parse error at
      line 9: internal error. (/repos/asf/!svn/bc/102002)
      
      The log message is:
      
      "Improve Spanish custom error messages.
      
      Submitted by: Sim^[,As^[(B <sim6 cataloniamail.com>
      Reviewed by:  Daniel Lopez <daniel rawbyte.com>"
      
      The ^[ are control characters.
      
      A svn propedit on the log will allow you to remove the control character though.
       (Which is sort of odd because it means the client is receiving it somehow.)
      
      There was a thread on dev@svn about it:
      
      http://svn.haxx.se/dev/archive-2004-11/1175.shtml
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            jerenkrantz Justin Erenkrantz
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: