Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2134

application/x-java-jnlp-file is not binary

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • 1.0.1
    • unscheduled
    • unknown
    • None

    Description

      I've got this JNLP file which is XML but I've marked its mime-type as
      application/x-java-jnlp-file so that the browser will launch Java Web
      Start. However, now I get this when I try to diff the file:
      
          Index: jws/Foo.jnlp
          ===================================================================
          Cannot display: file marked as a binary type.
          svn:mime-type = application/x-java-jnlp-file
      
      I'd like to convince Subversion that this particular type is actually
      text.
      
      This could be done:
      
      1. by adding "application/x-java-jnlp-file" to the internal list of text-types
      [suggested by Ben Collins-Sussman]
      
      2. to allow the client's run-time 'config' file to define a custom list of
      textual mime-types [suggested by Ben Collins-Sussman]
      
      3. by adding an extra property svn:text to indicate once and for all whether a
      file is to be treated as text or not [suggested by Rob Oxspring].
      
      Rob continues: 
      
          The algorithm would become:
      
          if svn:text is set
                  treat as svn:text value
          else if mimetype looks like text
                  treat as text
          else
                  treat as binary
      
          This would finally stop svn conflating the two questions "is the file text
          based?" and "what's the mime-type", while keeping the current heuristic as
          a backup. It also means that the configuration is server side from the
          beginning and doesn't need users to change their config files to get the
          benefit. If people want to set it using auto-props they can do.
      
          It has a side effect that the option can be configured on a file by file
          basis, but I'm not 100% sure that this is a bad thing anyway.
      
      Any of these seem fine to me. However, since I find the client config file to
      be an ongoing cause of broken MIME types and eol-styles at our organization
      and feel it should be moved to the server, my bias in this particular issue
      would be for one that was server-based (which means I probably lean towards
      solution #1).
      
      See users@subversion.tigris.org thread: Textual binaries
      

      Original issue reported by wohler

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              subversion-importer Subversion Importer
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: