Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1818

'svnadmin hotcopy' backup may copy files unsafely

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • all
    • 1.1.0
    • svnadmin
    • None

    Description

      'svnadmin hotcopy' calls svn_fs_hotcopy_berkeley(), which ultimately ends up
      calling apr_file_copy() on each table-file.  apr_file_copy() just reads BUFSIZ
      bytes at a time into a buffer and writes them back out again.  
      
      According to BDB's docs, this might be problematic, we need to do more research
      on this.  Here's some theoretical background from sleepycat:
      
      http://www.sleepycat.com/docs/ref/transapp/reclimit.html
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sussman Ben Collins-Sussman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment