Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1804

mailer.py doesn't catch SMTPRecipientsRefused in finish()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: all
    • Fix Version/s: 1.14.0
    • Component/s: tools
    • Labels:
      None
    • Environment:

      Windows 3.1

      Description

      I haven't decided if this is a bug or a feature yet.  I can see some advantages to either method.  That 
      said, I'm adding it as an issue anyway because it makes generic project type handling problematic.
      
      finish() of mailer.py does not attempt to catch the exception SMTPRecipientsRefused, which is raised if 
      the recipient of the destined mail does not exist.  This blocks any other mails that might be sent out as 
      well.  Given the commit has already happened, and the lack of error/message reporting of the hook 
      system in general, my solution was just to catch the exception and pass.  I'm not sure whether or not 
      I'm satisfied with that solution though, as a message should probably be sent to stderr.
      

      Original issue reported by rzigweid

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              subversion-importer Subversion Importer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: