Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1795

svnadmin load wrongly computes copyfrom-rev

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • all
    • 1.1.0
    • svnadmin
    • None

    Description

      As I learned somewhere (I don't remember), svnadmin load can take dump files
      with non-consecutive revision numbers. The non-consecutiveness can be caused by,
      say, manually modification of the dump file, or some dump filter.
      
      However, when computing the copyfrom-rev, svnadmin sometimes makes mistakes. I
      have a real-world case but it might be too big to upload here. Before I make a
      toy example for this bug report, here is the situation that the mistake might
      happen:
      
      Revision 59:
      copyfrom-rev: 52
      
      Even if some revisions between 52 and 59 (say, r54 & r55) have been removed from
      the dump file, the svnadmin still uses the relative distance (this case,
      59-52=7) for the load operation. Thus svnadmin generates something like
      
      Revision: 21
      copyfrom-rev: 14
      
      Instead of the correct one:
      
      Revision: 21
      copyfrom-rev: 16
      

      Original issue reported by ling

      Attachments

        1. 1_svnadmin-load-rev-offset.patch
          2 kB
          Subversion Importer
        2. 2_svnadmin-load-rev-offset.patch
          2 kB
          Subversion Importer
        3. 3_svnadmin-load-rev-offset-2.patch
          2 kB
          Subversion Importer
        4. 4_1795.sh
          0.6 kB
          Max Oliver Bowsher

        Activity

          People

            Unassigned Unassigned
            subversion-importer Subversion Importer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: