Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1465

svnserve crash

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • 1.0.0
    • svnserve
    • None
    • Windows XP

    Description

      If a pre-commit hook fails, svnserve may crash.  It appears that the
      commit function in serve.c is depending on the author and date
      variables being setup during the svn_ra_svn_drive_editor call, but
      that is not happening if a pre-commit hook returns an error.  So,
      depending on the stack state, bad pointers may be passed to
      svn_ra_svn_write_tuple.
      
      Simply initializing date and author to NULL or "" seems to work, but
      I'm not sure if that's the correct fix.
      
      Can someone comment on what the appropriate behavior should be here?
      

      http://www.contactor.se/~dast/svn/archive-2003-08/0177.shtml

      Original issue reported by djh

      Attachments

        Activity

          People

            Unassigned Unassigned
            subversion-importer Subversion Importer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: