Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1310

iteration pools should be cleared at beginning of each iteration

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: all
    • Fix Version/s: nonblocking
    • Component/s: src
    • Labels:

      Description

      Most current iteration pools are cleared at the end of each iteration, 
      and destroyed after the loop terminates.
      
      However, if there are 'continue' statements in the loop body, the pool 
      may not get cleared.
      
      Placing the call to 'svn_pool_clear' at the *beginning* of the loop body 
      will solve this problem.
      
      This issue is a reminder to change existing code to use the new 
      convention.  (The HACKING document will also be updated to reflect the 
      new usage.)
      

      Original issue reported by bdenny

        Attachments

        1. 1_diff.txt
          29 kB
          Subversion Importer
        2. 2_tests-diff.txt
          16 kB
          Subversion Importer
        3. 3_diff.txt
          26 kB
          Subversion Importer

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              subversion-importer Subversion Importer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: