Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1101

updates should receive checksums via a live prop, like checkouts

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • 0.23
    • libsvn_ra_neon
    • None

    Description

      During updates, the server sends expected checksums to the client as
      XML attributes.  See these in revision 4429:
      
         libsvn_ra_dav/fetch.c: start_element(), the ELEM_add_file case
         mod_dav_svn/update.c: insert_checksum_attributes() and its callers
      
      Checkouts, however, send the result_checksum as a new liveprop, see
      these, also in revision 4429:
      
         libsvn_ra_dav/fetch.c: svn_ra_dav__get_file()
         mod_dav_svn/liveprops.c: dav_svn_insert_prop()
      
      Updates should be getting their result_checksums the same way as
      checkouts, since the liveprop is there anyway.  So that attribute will
      disappear, though the base-checksum stays (it wouldn't make any sense
      for file foo to record its own base_checksums, as that's about the
      base text for this particular update, not about foo itself).
      
      However, one of the things we had to do before adding this live prop
      to update responses was make the client tolerate it.  See the same
      revision's change to 
      
         libsvn_ra_dav/fetch.c: validate_element()
      
      for how we did that.  When that change has had a chance to propagate
      to users, we can enable the live prop on the server and change the
      client code to actually use the prop.
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            kfogel Karl Fogel
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: