[SUREFIRE-638] Plugin cannot handle "java" in a path name

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.4.3, 2.5, 2.6
• Fix Version/s: 2.7
• Component/s: Maven Surefire Plugin
• Assignee: Unassigned
• Reporter: Sebb
• Created: 16/Aug/10 09:44
• Updated: 07/Apr/15 18:54
• Resolved: 17/Aug/10 00:26

Description

See SUREFIRE-536
================

Commons SCXML had the following include:

<include>org/apache/commons/scxml/env/javascript/EnvJavaScriptTestSuite.java</include>

However, the suite was not being found and executed.

A bit of experimentation showed that the problem is the string "java" in the pathname.

A work-round is to use:

<include>org/apache/commons/scxml/env/j*avascript/EnvJavaScriptTestSuite.java</include>
or
<include>org/apache/commons/scxml/env/jav*ascript/EnvJavaScriptTestSuite.java</include>
or
<include>org/apache/commons/scxml/env/*/EnvJavaScriptTestSuite.java</include>
etc.

This appears to be due to the following code in SurefireDirectoryScanner.processIncludesExcludes():

incs[i] = StringUtils.replace( (String) list.get( i ), "java", "class" );

Changing this to

incs[i] = StringUtils.replace( (String) list.get( i ), ".java", ".class" );

would be better than nothing, however that would still fail on a directory name that contains ".java" (perhaps not very likely).

What is really needed is to only replace the ".java" if it appears at the end of the string.

Issue Links

• is duplicated by: SUREFIRE-536 Plugin cannot handle "java" in a path name