Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-2247

Don't print stack trace when IT fails

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      Here's some output from a recent failing test:

      ```
      [INFO] BUILD FAILURE
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 09:05 min (Wall Clock)
      [INFO] Finished at: 2024-05-30T22:53:53-07:00
      [INFO] ------------------------------------------------------------------------
      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project presto-prism-plugin: There are test failures.
      [ERROR]
      [ERROR] Please refer to /data/sandcastle/boxes/eden-trunk-hg-full-fbsource/fbcode/github/presto-facebook-trunk/presto-prism-plugin/target/surefire-reports for the individual test results.
      [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
      [ERROR] -> [Help 1]
      org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project presto-prism-plugin: There are test failures.

      Please refer to /data/sandcastle/boxes/eden-trunk-hg-full-fbsource/fbcode/github/presto-facebook-trunk/presto-prism-plugin/target/surefire-reports for the individual test results.
      Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
      at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
      at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
      at java.util.concurrent.FutureTask.run (FutureTask.java:264)
      at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
      at java.util.concurrent.FutureTask.run (FutureTask.java:264)
      at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
      at java.lang.Thread.run (Thread.java:829)
      Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

      Please refer to /data/sandcastle/boxes/eden-trunk-hg-full-fbsource/fbcode/github/presto-facebook-trunk/presto-prism-plugin/target/surefire-reports for the individual test results.
      Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
      at org.apache.maven.plugin.surefire.SurefireHelper.throwException (SurefireHelper.java:283)
      at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution (SurefireHelper.java:171)
      at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary (SurefirePlugin.java:546)
      at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked (AbstractSurefireMojo.java:1183)
      at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute (AbstractSurefireMojo.java:931)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
      at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
      at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
      at java.util.concurrent.FutureTask.run (FutureTask.java:264)
      at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
      at java.util.concurrent.FutureTask.run (FutureTask.java:264)
      at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
      at java.lang.Thread.run (Thread.java:829)
      ```

      The stack traces are redundant and unhelpful. My test failed. OK. Tell me that. There's no use to printing the stack traces. That's not the problem and never was. The plugin executed correctly. The stack trace is noise that has nothing to do with the actual failure in my own code.

      Stack traces of Maven code should only appear when Maven fails, not when the user's code fails.

      Attachments

        Activity

          People

            Unassigned Unassigned
            elharo Elliotte Rusty Harold
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: