[SUREFIRE-2220] SurefireForkChannel#getForkNodeConnectionString() returns invalid URI string if localHost resolves to IPv6 address

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.2
• Fix Version/s: 3.2.3
• Component/s: process forking
• Assignee: Michael Osipov
• Reporter: Lutz Neugebauer
• Created: 06/Dec/23 15:40
• Updated: 09/Dec/23 10:14
• Resolved: 09/Dec/23 10:14

Description

SurefireForkChannel.getForkNodeConnectionString returns invalid URI string if localhost is an IPv6 address literal:

    public String getForkNodeConnectionString() {
        return "tcp://" + localHost + ":" + localPort + (isBlank(sessionId) ? "" : "?sessionId=" + sessionId);
    } 

localHost is initialized from InetSocketAddress.getHostString() at SurefireForkChannel.SurefireForkChannel() which may return "... the String form of the address if it doesn't have a hostname (it was created using a literal)."

If an IPv6 address is returned, then the URI computed is something like

tcp://0:0:0:0:0:0:0:1:34398?sessionId=... 

instead of required format (cf. URI.URI())

tcp://[0:0:0:0:0:0:0:1]:34398?sessionId=...  

At my end the incorrect URI seems to cause hanging build, probably when it is consumed at SurefireMasterProcessChannelProcessorFactory.connect().

Issue Links

• links to: GitHub Pull Request #697