[SUREFIRE-2210] Additional class path ordering broken since 3.2.0

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.2.1, 3.2.2
• Fix Version/s: 3.2.3
• Assignee: Konrad Windszus
• Reporter: David M. Lloyd
• Created: 10/Nov/23 14:06
• Updated: 09/Dec/23 20:22
• Resolved: 14/Nov/23 08:36

Description

Since commit 47eb1974ef2fb77c621e5cb0c47ac10ab8f4753d (#667, SUREFIRE-2179), the ordering of the additionalClasspathElements list configuration property is no longer preserved. This breaks testing of multi-release JARs, where the directories for newer JDKs must be strictly ordered before the directories for older JDKs.

The problem is likely due to changing the additional class paths collection from a `List` to a `Set`, which does not preserve ordering.

One simple fix could be to change the line Set<String> additionalClasspathElements = new HashSet<>(); to construct a LinkedHashSet instead.

/cc kwin who wrote the original patch back in June.

Issue Links

• links to: GitHub Pull Request #686