[SUREFIRE-1815] Thread interrupted state cleared on any console output

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-M5
• Fix Version/s: 3.0.0-M6
• Component/s: Maven Surefire Plugin
• Assignee: Tibor Digana
• Reporter: Scott Davis
• Created: 02/Jul/20 18:12
• Updated: 03/Feb/22 02:29
• Resolved: 06/Jul/20 15:48

Description

Thread interrupt state is cleared on any output in Surefire 3.0.0-M5; this does not occur in 3.0.0-M4 (all 4 test cases pass with flying colors).

I've reproduced this with the following JDK/OS combinations:

• OpenJDK 8 (Ubuntu 16) with build and source for the compiler plugin as Java 1.8.
• Corretto 8 (macOS 11.15) with build and source for the compiler plugin as Java 1.8.
• Corretto 11 (macOS 11.15) with build and source for the compiler plugin as Java 11.
• Corretto 11 (Ubuntu 20) with build and source for the compiler plugin as Java 1.8.
• Corretto 11 (Ubuntu 20) with build and source for the compiler plugin as Java 11.

With the exception of Ubuntu 16, all testing was done with Maven 3.6.3 downloaded directly from the Maven download page. All tests used Maven compiler plugin version 3.8.1.

I have attached a unit test file that can be used to reproduce this.

Expected result output from 3.0.0-M4 (success):

[*INFO*] -- maven-surefire-plugin:3.0.0-M4:test (default-test) @ jsandbox --

[*INFO*] 

[*INFO*] -------------------------------------------------------

[*INFO*]  T E S T S

[*INFO*] -------------------------------------------------------

[*INFO*] Running io.isaki.jsandbox.SurefirePluginTest

1A INTERRUPT: true

2A INTERRUPT: true

1B INTERRUPT: true

2B INTERRUPT: true

1C INTERRUPT: true

2C INTERRUPT: true

D: This is a sentence.

[*INFO*] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 s - in io.isaki.jsandbox.SurefirePluginTest

[*INFO*] 

[*INFO*] Results:

[*INFO*] 

[*INFO*] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[*INFO*] 

[*INFO*] ------------------------------------------------------------------------

[*INFO*] BUILD SUCCESS

[*INFO*] ------------------------------------------------------------------------

[*INFO*] Total time:  3.111 s

[*INFO*] Finished at: 2020-07-02T14:10:09-04:00

[*INFO*] ------------------------------------------------------------------------

Result output from 3.0.0-M5 (error):

[*INFO*] -- maven-surefire-plugin:3.0.0-M5:test (default-test) @ jsandbox --

[*INFO*] 

[*INFO*] -------------------------------------------------------

[*INFO*]  T E S T S

[*INFO*] -------------------------------------------------------

[*INFO*] Running io.isaki.jsandbox.SurefirePluginTest

1A INTERRUPT: true

2A INTERRUPT: false

1B INTERRUPT: true

2B INTERRUPT: false

1C INTERRUPT: true

2C INTERRUPT: false

D: This is a sentence.

[*ERROR*] Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.078 s <<< FAILURE! - in io.isaki.jsandbox.SurefirePluginTest

[*ERROR*] io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateA  Time elapsed: 0.023 s  <<< FAILURE!

java.lang.AssertionError

at io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateA(SurefirePluginTest.java:44)

 

[*ERROR*] io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateB  Time elapsed: 0.001 s  <<< FAILURE!

java.lang.AssertionError

at io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateB(SurefirePluginTest.java:75)

 

[*ERROR*] io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateD  Time elapsed: 0.001 s  <<< FAILURE!

java.lang.AssertionError

at io.isaki.jsandbox.SurefirePluginTest.testInterruptedStateD(SurefirePluginTest.java:136)

 

[*INFO*] 

[*INFO*] Results:

[*INFO*] 

[*ERROR*] Failures: 

[*ERROR*]   SurefirePluginTest.testInterruptedStateA:44

[*ERROR*]   SurefirePluginTest.testInterruptedStateB:75

[*ERROR*]   SurefirePluginTest.testInterruptedStateD:136

[*INFO*] 

[*ERROR*] Tests run: 4, Failures: 3, Errors: 0, Skipped: 0

[*INFO*] 

[*INFO*] ------------------------------------------------------------------------

[*INFO*] BUILD FAILURE

[*INFO*] ------------------------------------------------------------------------

[*INFO*] Total time:  2.891 s

[*INFO*] Finished at: 2020-07-02T14:07:55-04:00

[*INFO*] ------------------------------------------------------------------------

[*ERROR*] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project jsandbox: There are test failures.

[*ERROR*] 

[*ERROR*] Please refer to /Users/isaki/git/jsandbox/target/surefire-reports for the individual test results.

[*ERROR*] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

[*ERROR*] -> [Help 1]

[*ERROR*] 

[*ERROR*] To see the full stack trace of the errors, re-run Maven with the -e switch.

[*ERROR*] Re-run Maven using the -X switch to enable full debug logging.

[*ERROR*] 

[*ERROR*] For more information about the errors and possible solutions, please read the following articles:

[*ERROR*] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Issue Links

• is duplicated by: SUREFIRE-1863 Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.
• is duplicated by: SUREFIRE-1973 Tests fail in 3.0.0-M5 but Pass in 3.0.0-M4
• links to: GitHub Pull Request #304