[SUREFIRE-1541] SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.22.0
• Component/s: Maven Surefire Plugin
• Assignee: Tibor Digana
• Reporter: Anghel Botos
• Created: 24/Jul/18 10:27
• Updated: 04/Dec/19 12:30
• Resolved: 09/Nov/18 16:34

Description

Attempting to run integration tests using maven-failsafe-plugin with -Dmaven.failsafe.debug=false yields the following stacktrace:
 

[ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was cmd.exe /X /C ""C:\Program Files\Java\jdk1.8.0_121\jre\bin\java" false -jar C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp surefire_411836142070426630764tmp"
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 1
[ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
[ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
[ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
[ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)

 

The issue is the "free-floating" false that appears in the command line used to start a new JVM. I've traced down the issue to org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess where the following code can be found:

        String debugForkedProcess = getDebugForkedProcess();
        if ( "true".equals( debugForkedProcess ) )
        {
            return "-Xdebug -Xnoagent -Djava.compiler=NONE"
                + " -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
        }
        return debugForkedProcess;

...which is quite..."unexpected" to see that one can pass in a value of true, but not a value of false.

Please fix with a proper parsing of true/false values for the maven.failsafe.debug property.

Issue Links

• duplicates: SUREFIRE-1588 Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8