Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1522

IndexOutOfBoundsException for System.out.write

    Details

      Description

      There is a regression, I believe caused by SUREFIRE-1454. Git blame seems to confirm this; and there was a related regression for empty arrays SUREFIRE-1515.

      It can be easily reproduced with the following test:

       

      import org.junit.jupiter.api.Test;
      
      import java.nio.charset.StandardCharsets;
      
      public class SurefireLoggingTest {
      
          private final byte[] aNiceString = "what fun times, standard out is broken\n".getBytes(StandardCharsets.US_ASCII);
      
          @Test
          public void fun() {
              System.out.write(aNiceString, 5, 3);
          }
      
          @Test
          public void fun_times() {
              System.out.write(aNiceString, 5, 9);
          }
      }
      

       

      Both tests will pass under Intellij, writing "fun" and "fun times" to System.out. Whereas, with Surefire capturing standard out when running from maven, only fun_times() passes. fun() will fail with:

       

      java.lang.IndexOutOfBoundsException: off < 0 || len < 0 || off >= input.length || len > input.length || off > len

       

      If you look at the Javadoc contract for PrintStream.write(byte buf[], int off, int len), you can see that len is "Number of bytes to write", so you can see that it should be fine to print the substring "fun", of length 3, at offset 5. And indeed that is what happens in Intellij.

       

      I suspect that the failing test isolates the problem to when the offset "exceeds" the length of the substring. The wrong length is being checked in StringUtils.escapeBytesToPrintable(). I think that the check intended to ensure the offset didn't exceed the end of the byte array, not the length of the slice. But that is already covered by "off >= input.length". So there is no benefit to also checking "off > len".

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tibordigana Tibor Digana
                Reporter:
                rob.platt Rob Platt
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: