Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1324

Surefire incorrectly suppresses exceptions when closing resources.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.20
    • Component/s: None
    • Labels:
      None

      Description

      There are various places where exceptions thrown when closing resources are suppressed although they should be handled. Additionally, the PrintStream class does not throw exceptions but provides a checkError method to be used instead. This method has not been used after writing to the PrintStream.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-surefire #1671 (See https://builds.apache.org/job/maven-surefire/1671/)
          Revert "[MSUREFIRE-1324] Surefire incorrectly suppresses exceptions when (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=0dbb5bb8a6522cc50a3609c353f0f7802946c0e2)

          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
            Revert "SUREFIRE-1324 Surefire incorrectly suppresses exceptions when (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=1c9df460e2e7e7ddaee9c0fe4ca79fe895744577)
          • (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ThreadedStreamConsumer.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java
          • (edit) surefire-api/pom.xml
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
          • (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java
          • (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
          • (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java
          • (delete) surefire-api/src/main/java/org/apache/maven/surefire/booter/DumpErrorSingleton.java
          • (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/LostCommandsDumpSingleton.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
          • (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1671 (See https://builds.apache.org/job/maven-surefire/1671/ ) Revert " [MSUREFIRE-1324] Surefire incorrectly suppresses exceptions when (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=0dbb5bb8a6522cc50a3609c353f0f7802946c0e2 ) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java Revert " SUREFIRE-1324 Surefire incorrectly suppresses exceptions when (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=1c9df460e2e7e7ddaee9c0fe4ca79fe895744577 ) (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ThreadedStreamConsumer.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java (edit) surefire-api/pom.xml (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java (delete) surefire-api/src/main/java/org/apache/maven/surefire/booter/DumpErrorSingleton.java (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/LostCommandsDumpSingleton.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in Jenkins build maven-surefire #1667 (See https://builds.apache.org/job/maven-surefire/1667/)
          SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968)

          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
          • (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java
          • (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java
          • (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
          • (edit) surefire-api/pom.xml
          • (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
          • (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java
          • (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java
          • (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java
          • (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java
            SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=8004064be0f1e40539cd7879aa7752a78af97891)
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in Jenkins build maven-surefire #1667 (See https://builds.apache.org/job/maven-surefire/1667/ ) SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968 ) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java (edit) surefire-api/pom.xml (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=8004064be0f1e40539cd7879aa7752a78af97891 ) (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-surefire #1665 (See https://builds.apache.org/job/maven-surefire/1665/)
          SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (tibor17: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=201a3134673f3794d71262bdf1cf057bbb3d1056)

          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ThreadedStreamConsumer.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
          • (add) surefire-api/src/main/java/org/apache/maven/surefire/booter/DumpErrorSingleton.java
          • (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java
          • (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java
          • (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
          • (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
          • (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
          • (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/LostCommandsDumpSingleton.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
          • (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java
          • (edit) surefire-api/pom.xml
          • (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1665 (See https://builds.apache.org/job/maven-surefire/1665/ ) SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (tibor17: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=201a3134673f3794d71262bdf1cf057bbb3d1056 ) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ThreadedStreamConsumer.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java (add) surefire-api/src/main/java/org/apache/maven/surefire/booter/DumpErrorSingleton.java (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/LostCommandsDumpSingleton.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java (edit) surefire-api/pom.xml (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
          Show
          tibor17 Tibor Digana added a comment - https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h=201a3134673f3794d71262bdf1cf057bbb3d1056
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 closed the pull request at:

          https://github.com/apache/maven-surefire/pull/139

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/139
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven-surefire/pull/139

          @britter
          @ChristianSchulte
          If you have no objections to this I will push it to master. Thx.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/139 @britter @ChristianSchulte If you have no objections to this I will push it to master. Thx.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Tibor17 opened a pull request:

          https://github.com/apache/maven-surefire/pull/139

          SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing resources.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1324

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven-surefire/pull/139.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #139


          commit 2cf58708f6798f04d0314dce5df4c0ed5c2a09d3
          Author: Tibor17 <tibor17@lycos.com>
          Date: 2017-01-07T02:55:07Z

          SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing resources.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/139 SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing resources. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1324 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit 2cf58708f6798f04d0314dce5df4c0ed5c2a09d3 Author: Tibor17 <tibor17@lycos.com> Date: 2017-01-07T02:55:07Z SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing resources.
          Hide
          tibor17 Tibor Digana added a comment -

          reopened to code review

          Show
          tibor17 Tibor Digana added a comment - reopened to code review
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-surefire #1664 (See https://builds.apache.org/job/maven-surefire/1664/)
          SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968)

          • (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java
          • (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java
          • (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
          • (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
          • (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java
          • (edit) surefire-api/pom.xml
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
          • (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java
          • (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1664 (See https://builds.apache.org/job/maven-surefire/1664/ ) SUREFIRE-1324 Surefire incorrectly suppresses exceptions when closing (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968 ) (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java (edit) surefire-integration-tests/src/test/resources/testng-listener-reporter/src/test/java/listenReport/FileHelper.java (edit) surefire-api/src/main/java/org/apache/maven/plugin/surefire/runorder/RunEntryStatisticsMap.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/FailingTest.java (edit) surefire-integration-tests/src/test/resources/surefire-803-multiFailsafeExec-failureInFirst/src/test/java/org/apache/maven/surefire/test/SucceedingTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java (edit) surefire-integration-tests/src/test/resources/testng-testRunnerFactory/src/test/java/testng/testrunnerfactory/FileHelper.java (edit) surefire-integration-tests/src/test/resources/classpath-order/src/test/java/it/BasicTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/report/FileReporterTest.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java (edit) surefire-integration-tests/src/test/resources/test-helper-dump-pid-plugin/src/main/java/org/apache/maven/plugins/surefire/dumppid/DumpPidMojo.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/TestFile.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/MasterProcessCommand.java (edit) surefire-api/pom.xml (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java (edit) surefire-integration-tests/src/test/resources/junit4-runlistener/src/test/java/runListener/FileHelper.java (edit) surefire-integration-tests/src/test/resources/testng-objectFactory/src/test/java/testng/objectfactory/FileHelper.java

            People

            • Assignee:
              tibor17 Tibor Digana
              Reporter:
              schulte77 Christian Schulte
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development