Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1315

Fix stylistic errors in DefaultReporterFactory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.19.1
    • Fix Version/s: 2.20
    • Component/s: None
    • Labels:

      Description

      I'm using maven from CLI:

      mvn --version
      Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T17:57:37+06:00)
      Maven home: /usr/lib/maven/3.3.3
      Java version: 1.8.0_91, vendor: Oracle Corporation
      Java home: /usr/lib/jvm/java-8-oracle/jre
      Default locale: en_US, platform encoding: UTF-8
      OS name: "linux", version: "4.4.0-38-generic", arch: "amd64", family: "unix"

      When some unit test fails, mvn shows following message:

      Results :
      Tests in error:
      ...

      I think this message should be

      Errors in tests:

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-surefire #1657 (See https://builds.apache.org/job/maven-surefire/1657/)
        SUREFIRE-1315 Fix stylistic errors in DefaultReporterFactory (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=bd75bac320301db3fc4d8aec5b431f4d10171eb9)

        • (edit) maven-surefire-plugin/src/site/markdown/newerrorsummary.md
        • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java
        • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
        • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit4RerunFailingTestsIT.java
        • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1146RerunFailedAndParameterized.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1657 (See https://builds.apache.org/job/maven-surefire/1657/ ) SUREFIRE-1315 Fix stylistic errors in DefaultReporterFactory (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=bd75bac320301db3fc4d8aec5b431f4d10171eb9 ) (edit) maven-surefire-plugin/src/site/markdown/newerrorsummary.md (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit4RerunFailingTestsIT.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1146RerunFailedAndParameterized.java
        Hide
        michael-o Michael Osipov added a comment -

        Subsequent refinement with bd75bac320301db3fc4d8aec5b431f4d10171eb9.

        Show
        michael-o Michael Osipov added a comment - Subsequent refinement with bd75bac320301db3fc4d8aec5b431f4d10171eb9 .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-surefire #1655 (See https://builds.apache.org/job/maven-surefire/1655/)
        SUREFIRE-1315 Fix stylistic errors in DefaultReporterFactory (michaelo: rev dcd3b64acf129e630c6aaec9b2e1f48476855bad)

        • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1146RerunFailedAndParameterized.java
        • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java
        • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
        • (edit) maven-surefire-plugin/src/site/markdown/newerrorsummary.md
        • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit4RerunFailingTestsIT.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1655 (See https://builds.apache.org/job/maven-surefire/1655/ ) SUREFIRE-1315 Fix stylistic errors in DefaultReporterFactory (michaelo: rev dcd3b64acf129e630c6aaec9b2e1f48476855bad) (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1146RerunFailedAndParameterized.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java (edit) maven-surefire-plugin/src/site/markdown/newerrorsummary.md (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit4RerunFailingTestsIT.java
        Hide
        michael-o Michael Osipov added a comment -
        Show
        michael-o Michael Osipov added a comment - Fixed with dcd3b64acf129e630c6aaec9b2e1f48476855bad .
        Hide
        michael-o Michael Osipov added a comment - - edited

        I just went down the history with blame and the string was introduced by a non-native English speaker (fefaae7f0534a59f52c046a64c96987e8561dd48). He likely meant that are tests failing with errors but wrote instead error is tested with tests. Same applies for "Flaked tests". It should rather read "Flaky tests".

        Show
        michael-o Michael Osipov added a comment - - edited I just went down the history with blame and the string was introduced by a non-native English speaker (fefaae7f0534a59f52c046a64c96987e8561dd48). He likely meant that are tests failing with errors but wrote instead error is tested with tests. Same applies for "Flaked tests". It should rather read "Flaky tests".
        Hide
        gboue Guillaume Boué added a comment -

        (Non-native speaker) What is the difference in meaning? The list after that message is showing each method of each test class where an unexpected exception was thrown, so it lists the tests that ended with an error. (It is different from a test that failed, which is a test where one of the assertions being made wasn't verified, see here also.)

        Show
        gboue Guillaume Boué added a comment - (Non-native speaker) What is the difference in meaning? The list after that message is showing each method of each test class where an unexpected exception was thrown, so it lists the tests that ended with an error. (It is different from a test that failed, which is a test where one of the assertions being made wasn't verified, see here also .)

          People

          • Assignee:
            michael-o Michael Osipov
            Reporter:
            samsonbek Abdysamat Mamutov
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development